Bug 904328

All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.

Need sponsor.

bug 903824 perl-Convert-Age.spec
bug 903826 perl-Net-Domain-TLD.spec
bug 903829 perl-Time-Interval.spec
bug 904328 perl-Config-ApacheFormat.spec
bug 904329 perl-Data-Validate-Domain.spec
bug 904330 perl-Data-Validate-IP.spec
bug 904331 perl-Shell.spec

Thanks.

Taking the review.

Issues similar to those of other reviews...

Missing build-time dependency:
perl(Carp)

Unneeded runtime dependencies:
perl(Class::MethodMaker)
perl(File::Spec)
perl(Scalar::Util)
perl(Text::Balanced)
Those are automatically picked up by rpmbuild.

Lines 40 and 41 are unneeded.  None of the files has executable bits set.
Line 52 is also unneeded (done by rpmbuild).

And the command macros could be replaced with simple calls.

Spec file and src package updated.

 * Fixed dependencies.
 * Replaced macros with simple commands.
 * Removed useless lines

New package overwritten in original location.

Removing FE-NEEDSPONSOR.

I see you also added the Data::Dumper dependency.  Its only used in the dump() subroutine which is not called from the tests at all.  You may drop this again :)

And again, that %{__perl} macro in MODULE_COMPAT...

Not approving yet.

Moved Data::Dumper to Requires, removed macro. Please check. 

Thanks.

(In reply to comment #7)
> Moved Data::Dumper to Requires

Good.  Indeed, it wasn't autodetected in this case.
perl(Class::MethodMaker), on the other hand, is.  Why did you add it now?

I see you've removed your email address from the changelog here too; why?
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs

> [...] wasn't autodetected in this case.
> perl(Class::MethodMaker), on the other hand, is.  Why did you add it now?
Still getting used to rpmbuild behavior. I was assuming that if rpmbuild detects Requirement and requirement is specified in spec file, it will show duplicate Requirement in rpm --requires output.

 * perl(Class::MethodMaker) removed from Requirements.
 * Added obfuscated e-mail.

Thanks.

(In reply to comment #9)
> > [...] wasn't autodetected in this case.
> > perl(Class::MethodMaker), on the other hand, is.  Why did you add it now?
> Still getting used to rpmbuild behavior. I was assuming that if rpmbuild
> detects Requirement and requirement is specified in spec file, it will show
> duplicate Requirement in rpm --requires output.

It used to be like that.  Not anymore.  The duplicates get filtered out.

>  * perl(Class::MethodMaker) removed from Requirements.

Ok.

>  * Added obfuscated e-mail.

*sigh* If you must... enclose it with qw(< >) at least.

Spec file/srpm updated, added <> to e-mail.

Another reviewer suggested to use simpler e-mail obfuscation, so, to be consistent, I changed it for all packages.

Alright, approving.

Thanks.

Adding fedora-cvs flag.

No SCM request found, unsetting flag.

Sorry for that. Re-trying.

New Package SCM Request
=======================
Package Name: perl-Config-ApacheFormat
Short Description: Use Apache format config files.
Owners: normunds psabata
Branches: f17 f18
InitialCC: perl-sig

Git done (by process-git-requests).

perl-Config-ApacheFormat-1.2-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-Config-ApacheFormat-1.2-1.fc17

perl-Config-ApacheFormat-1.2-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Config-ApacheFormat-1.2-1.fc18

perl-Config-ApacheFormat-1.2-1.fc18 has been pushed to the Fedora 18 stable repository.

perl-Config-ApacheFormat-1.2-1.fc17 has been pushed to the Fedora 17 stable repository.