Bug 904743

Summary: Empty setupNetowrk command is sent from engine to VDSM
Product: Red Hat Enterprise Virtualization Manager Reporter: Moti Asayag <masayag>
Component: ovirt-engineAssignee: Lior Vernia <lvernia>
Status: CLOSED CURRENTRELEASE QA Contact: Meni Yakove <myakove>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: acathrow, bazulay, dyasny, iheim, lpeer, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: SF7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Moti Asayag 2013-01-27 11:20:10 UTC
Description of problem:

When setupNetwork command is invoked, the engine calculates the differences between the latest reported configuration to the new configuration requested by the user.

Only the modified interfaces/networks are sent to VDSM.

When no changes are done in setupNetworks, the engine sends an empty command (no interfaces nor networks are specified) which makes the call to VDSM redundant.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. Run setupNetwork command.
2. Rerun setupNetwork command with no changes since previous command.
  
Actual results:
The engine sends an empty setupNetwork command to VDSM, which appears on VDSM logs setupNetwork command without any parameter:
 
Thread-238905::DEBUG::2013-01-21
13:35:04,830::BindingXMLRPC::894::vds::(wrapper) client
[10.65.210.91]::call setupNetworks with ({}, {}, {'connectivityCheck':
'true', 'connectivityTimeout': 120}) {} flowID [1967da34]

Expected results:
The call to VDSM should be spared.

Additional info:

Comment 3 Meni Yakove 2013-02-14 08:59:50 UTC
Verified on vdsm-4.10.2-8.0.el6ev.x86_64

Comment 4 Itamar Heim 2013-06-11 09:37:44 UTC
3.2 has been released

Comment 5 Itamar Heim 2013-06-11 09:37:47 UTC
3.2 has been released

Comment 6 Itamar Heim 2013-06-11 09:52:01 UTC
3.2 has been released