Bug 904743 - Empty setupNetowrk command is sent from engine to VDSM
Summary: Empty setupNetowrk command is sent from engine to VDSM
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.2.0
Assignee: Lior Vernia
QA Contact: Meni Yakove
URL:
Whiteboard: network
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-01-27 11:20 UTC by Moti Asayag
Modified: 2016-02-10 19:50 UTC (History)
9 users (show)

Fixed In Version: SF7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 11750 0 None None None Never

Description Moti Asayag 2013-01-27 11:20:10 UTC
Description of problem:

When setupNetwork command is invoked, the engine calculates the differences between the latest reported configuration to the new configuration requested by the user.

Only the modified interfaces/networks are sent to VDSM.

When no changes are done in setupNetworks, the engine sends an empty command (no interfaces nor networks are specified) which makes the call to VDSM redundant.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. Run setupNetwork command.
2. Rerun setupNetwork command with no changes since previous command.
  
Actual results:
The engine sends an empty setupNetwork command to VDSM, which appears on VDSM logs setupNetwork command without any parameter:
 
Thread-238905::DEBUG::2013-01-21
13:35:04,830::BindingXMLRPC::894::vds::(wrapper) client
[10.65.210.91]::call setupNetworks with ({}, {}, {'connectivityCheck':
'true', 'connectivityTimeout': 120}) {} flowID [1967da34]

Expected results:
The call to VDSM should be spared.

Additional info:

Comment 3 Meni Yakove 2013-02-14 08:59:50 UTC
Verified on vdsm-4.10.2-8.0.el6ev.x86_64

Comment 4 Itamar Heim 2013-06-11 09:37:44 UTC
3.2 has been released

Comment 5 Itamar Heim 2013-06-11 09:37:47 UTC
3.2 has been released

Comment 6 Itamar Heim 2013-06-11 09:52:01 UTC
3.2 has been released


Note You need to log in before you can comment on or make changes to this bug.