Bug 905286
| Summary: | Check if stream is closed before unlock() | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Amit Saha <asaha> |
| Component: | python-concurrentloghandler | Assignee: | Dan Callaghan <dcallagh> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | dcallagh, ebaak, pingou |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-concurrentloghandler-0.8.4-10.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-07-10 01:25:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Amit Saha
2013-01-29 04:03:53 UTC
Amit, do you have a traceback or any other details about why this is broken and needs to be changed? Under what circumstances is it a problem? Re-open if this is still an issue. Okay, I could reproduce this issue on F19. If you run beakerd in foreground mode:
# su apache -s /bin/bash -c "/usr/bin/beakerd -f"
and then try to kill it using Ctrl + C, you should be able to see this traceback:
Traceback (most recent call last):
File "/usr/lib64/python2.7/atexit.py", line 24, in _run_exitfuncs
func(*targs, **kargs)
File "/usr/lib64/python2.7/logging/__init__.py", line 1659, in shutdown
h.release()
File "/usr/lib/python2.7/site-packages/cloghandler.py", line 202, in release
unlock(self.stream_lock)
File "/usr/lib/python2.7/site-packages/portalocker.py", line 139, in unlock
fcntl.flock(_getfd(file), fcntl.LOCK_UN)
File "/usr/lib/python2.7/site-packages/portalocker.py", line 93, in _getfd
return file.fileno()
ValueError: I/O operation on closed file
If I add a check before attempting to unlock, it doesn't happen any more:
if not self.stream_lock.closed:
unlock(self.stream_lock)
# rpm -q python-concurrentloghandler
python-concurrentloghandler-0.8.4-9.fc19.noarch
python-concurrentloghandler-0.8.4-10.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-concurrentloghandler-0.8.4-10.fc19 python-concurrentloghandler-0.8.4-10.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-concurrentloghandler-0.8.4-10.fc18 python-concurrentloghandler-0.8.4-10.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-concurrentloghandler-0.8.4-10.fc17 Package python-concurrentloghandler-0.8.4-10.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-concurrentloghandler-0.8.4-10.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-11802/python-concurrentloghandler-0.8.4-10.fc18 then log in and leave karma (feedback). python-concurrentloghandler-0.8.4-10.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. python-concurrentloghandler-0.8.4-10.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. python-concurrentloghandler-0.8.4-10.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |