Description of problem: During release(), unlock() only if the stream hasn't yet been closed. Version-Release number of selected component (if applicable): python-concurrentloghandler-0.8.4-7.fc18.noarch How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: Should be fixable via a simple check in ConcurrentRotatingFileHander.release(): if not self.stream.closed: unlock(self.stream_lock)
Amit, do you have a traceback or any other details about why this is broken and needs to be changed? Under what circumstances is it a problem?
Re-open if this is still an issue.
Okay, I could reproduce this issue on F19. If you run beakerd in foreground mode: # su apache -s /bin/bash -c "/usr/bin/beakerd -f" and then try to kill it using Ctrl + C, you should be able to see this traceback: Traceback (most recent call last): File "/usr/lib64/python2.7/atexit.py", line 24, in _run_exitfuncs func(*targs, **kargs) File "/usr/lib64/python2.7/logging/__init__.py", line 1659, in shutdown h.release() File "/usr/lib/python2.7/site-packages/cloghandler.py", line 202, in release unlock(self.stream_lock) File "/usr/lib/python2.7/site-packages/portalocker.py", line 139, in unlock fcntl.flock(_getfd(file), fcntl.LOCK_UN) File "/usr/lib/python2.7/site-packages/portalocker.py", line 93, in _getfd return file.fileno() ValueError: I/O operation on closed file If I add a check before attempting to unlock, it doesn't happen any more: if not self.stream_lock.closed: unlock(self.stream_lock) # rpm -q python-concurrentloghandler python-concurrentloghandler-0.8.4-9.fc19.noarch
python-concurrentloghandler-0.8.4-10.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-concurrentloghandler-0.8.4-10.fc19
python-concurrentloghandler-0.8.4-10.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-concurrentloghandler-0.8.4-10.fc18
python-concurrentloghandler-0.8.4-10.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-concurrentloghandler-0.8.4-10.fc17
Package python-concurrentloghandler-0.8.4-10.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-concurrentloghandler-0.8.4-10.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-11802/python-concurrentloghandler-0.8.4-10.fc18 then log in and leave karma (feedback).
python-concurrentloghandler-0.8.4-10.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
python-concurrentloghandler-0.8.4-10.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
python-concurrentloghandler-0.8.4-10.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.