Bug 906248 (libkkc)

Created attachment 692302 [details]
mock build log

Just tried mockbuild.
Please make build log more verbose so that we can check if Fedora specific compilation flags are honored correctly.

Note that for this package I just tried mockbuild.

Updated the latest release and disabled silent rules.

Spec URL: http://ueno.fedorapeople.org/libkkc/libkkc.spec
SRPM URL: http://ueno.fedorapeople.org/libkkc/libkkc-0.1.1-1.fc18.src.rpm

Fixed some issues reported by Parag off-line.

Spec URL: http://ueno.fedorapeople.org/libkkc/libkkc.spec
SRPM URL: http://ueno.fedorapeople.org/libkkc/libkkc-0.1.2-1.fc18.src.rpm

Review:-
+ Koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4929607

+ rpmlint on rpms gave
libkkc.src: W: spelling-error %description -l en_US kkc -> kc, k kc, KC
libkkc.src: W: spelling-error %description -l en_US el -> e, l, eel
libkkc.x86_64: W: spelling-error %description -l en_US kkc -> kc, k kc, KC
libkkc.x86_64: W: spelling-error %description -l en_US el -> e, l, eel
libkkc-data.x86_64: W: no-documentation
libkkc-devel.x86_64: W: no-documentation
libkkc-tools.x86_64: W: no-documentation
libkkc-tools.x86_64: W: no-manual-page-for-binary kkc
6 packages and 0 specfiles checked; 0 errors, 8 warnings.

+ Source verified with upstream as
https://bitbucket.org/libkkc/libkkc/downloads/libkkc-0.1.2.tar.gz :
  CHECKSUM(SHA256) this package     : 885c34780b8f5318bb8a4276e6f331fad37f020442d5f720dfea75da3f100da6
  CHECKSUM(SHA256) upstream package : 885c34780b8f5318bb8a4276e6f331fad37f020442d5f720dfea75da3f100da6
https://bitbucket.org/libkkc/libkkc-data/downloads/libkkc-data-0.1.1.tar.gz :
  CHECKSUM(SHA256) this package     : eeaaf2a4dfc9e051da044874169be5385d2cd4f2a0785b1de705d9955f3f10dc
  CHECKSUM(SHA256) upstream package : eeaaf2a4dfc9e051da044874169be5385d2cd4f2a0785b1de705d9955f3f10dc

+ License is GPLv3+  and included in COPYING as well as some source files in libkkc tarball


Suggestions:
1) you can add ChangeLog from data tarball to -data as %doc

2) I see that -data installing just models and keymaps. This should be noarch package then.

Thanks, added ChangeLog of libkkc-data.  However, there is no assumption that the marisa format is arch-independent.  So I would like to leave the arch as it is. 

Spec URL: http://ueno.fedorapeople.org/libkkc/libkkc.spec
SRPM URL: http://ueno.fedorapeople.org/libkkc/libkkc-0.1.2-2.fc18.src.rpm

Well,

(In reply to comment #6)
> However, there is no assumption
> that the marisa format is arch-independent.

So treating "-data" rpms (like this kind) needs attention.
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA
says files under /usr/share should be "arch-independent", and https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Filesystem_Layout says packages in Fedora must follow FHS.

So if you are unsure data files are really arch-independent, you must move them to arch-dependent directory (i.e. %_libdir) and apply patches if needed.

I asked the author of marisa-trie and confirmed that the format might be arch-dependent on big endian systems.  So I'll do:

- re-package libkkc-data to generate marisa files when building
- enable python binding of marisa in Fedora, to get the generation script working
- modify libkkc to pick the files from %_libdir

Okay, I did those.

Spec URL: http://ueno.fedorapeople.org/libkkc/libkkc.spec
SRPM URL: http://ueno.fedorapeople.org/libkkc/libkkc-0.1.3-1.fc18.src.rpm

Suggestions:
1)python versioned BR should be used. You need BR: python2-devel
2)can we add further more packaging for -data?
 let noarch files be as -data noarch subpackage which will pull arch-ed files in -data-models

Updated, thanks.

Spec URL: http://ueno.fedorapeople.org/libkkc/libkkc.spec
SRPM URL: http://ueno.fedorapeople.org/libkkc/libkkc-0.1.3-2.fc18.src.rpm

(In reply to comment #10)
> 2)can we add further more packaging for -data?
>  let noarch files be as -data noarch subpackage which will pull arch-ed
> files in -data-models

I moved noarch data files to -common subpackage (noarch).

spec file looks good.

APPROVED.

New Package SCM Request
=======================
Package Name: libkkc
Short Description: Japanese Kana Kanji conversion library
Owners: ueno
Branches: f18 f17
InitialCC: i18n-team

Git done (by process-git-requests).

libkkc-0.1.5-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libkkc-0.1.5-1.fc18

libkkc-0.1.5-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libkkc-0.1.5-1.fc17

ibus-kkc-1.5.6-1.fc18, marisa-0.2.1-3.fc18, libkkc-0.1.5-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/marisa-0.2.1-3.fc18,libkkc-0.1.5-1.fc18,ibus-kkc-1.5.6-1.fc18

ibus-kkc-1.5.6-1.fc17, marisa-0.2.1-3.fc17, libkkc-0.1.5-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/marisa-0.2.1-3.fc17,libkkc-0.1.5-1.fc17,ibus-kkc-1.5.6-1.fc17

ibus-kkc-1.5.6-1.fc18, marisa-0.2.1-3.fc18, libkkc-0.1.5-1.fc18 has been pushed to the Fedora 18 stable repository.

ibus-kkc-1.5.6-1.fc17, marisa-0.2.1-3.fc17, libkkc-0.1.5-1.fc17 has been pushed to the Fedora 17 stable repository.