Bug 906245 - Review Request: marisa - static and space-efficient trie data structure library
Summary: Review Request: marisa - static and space-efficient trie data structure library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: libkkc
TreeView+ depends on / blocked
 
Reported: 2013-01-31 09:56 UTC by Daiki Ueno
Modified: 2013-02-23 01:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-04 02:57:25 UTC
Type: Bug
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daiki Ueno 2013-01-31 09:56:38 UTC
Spec URL: http://ueno.fedorapeople.org/marisa/marisa.spec
SRPM URL: http://ueno.fedorapeople.org/marisa/marisa-0.2.1-1.fc18.src.rpm
Description:
Matching Algorithm with Recursively Implemented StorAge (MARISA) is a
static and space-efficient trie data structure. And *libmarisa* is a
C++ library to provide an implementation of MARISA. Also, the package
of *libmarisa* contains a set of command line tools for building and
operating a MARISA-based dictionary.

A MARISA-based dictionary supports not only lookup but also reverse
lookup, common prefix search and predictive search.

Comment 1 Parag AN(पराग) 2013-01-31 17:35:49 UTC
some fixes are needed
1) This BR is not needed: gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
its already installed as minimal build environment

2) rpmlint complains about rpath
See: https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath

marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-predictive-search ['/usr/lib64']
marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-lookup ['/usr/lib64']
marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-build ['/usr/lib64']
marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-reverse-lookup ['/usr/lib64']
marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-benchmark ['/usr/lib64']
marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-common-prefix-search ['/usr/lib64']
marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-dump ['/usr/lib64']


3) Add docs/readme.en.html docs/style.css AUTHORS COPYING README as %docs to main package

4) if not building for EPEL then better drop
cleaning of buildroot in %install

5) preserve timestamp as
%make_install INSTALL="install -p"

Comment 2 Daiki Ueno 2013-02-01 01:51:02 UTC
Thanks, addressed the issues.

Spec URL: http://ueno.fedorapeople.org/marisa/marisa.spec
SRPM URL: http://ueno.fedorapeople.org/marisa/marisa-0.2.1-2.fc18.src.rpm

Comment 3 Parag AN(पराग) 2013-02-01 06:36:11 UTC
Review:
+ mock build worked fine for f18 x86_64 and also http://koji.fedoraproject.org/koji/taskinfo?taskID=4921012

+ rpmlint on rpms is giving
marisa.src: W: spelling-error Summary(en_US) spece -> spec, specie, specs
marisa.src: W: spelling-error Summary(en_US) trie -> tire, true, tie
marisa.src: W: spelling-error %description -l en_US trie -> tire, true, tie
marisa.src: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up
marisa.x86_64: W: spelling-error Summary(en_US) spece -> spec, specie, specs
marisa.x86_64: W: spelling-error Summary(en_US) trie -> tire, true, tie
marisa.x86_64: W: spelling-error %description -l en_US trie -> tire, true, tie
marisa.x86_64: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up
marisa-devel.x86_64: W: no-documentation
marisa-tools.x86_64: W: no-documentation
marisa-tools.x86_64: W: no-manual-page-for-binary marisa-dump
marisa-tools.x86_64: W: no-manual-page-for-binary marisa-common-prefix-search
marisa-tools.x86_64: W: no-manual-page-for-binary marisa-lookup
marisa-tools.x86_64: W: no-manual-page-for-binary marisa-build
marisa-tools.x86_64: W: no-manual-page-for-binary marisa-benchmark
marisa-tools.x86_64: W: no-manual-page-for-binary marisa-predictive-search
marisa-tools.x86_64: W: no-manual-page-for-binary marisa-reverse-lookup
4 packages and 0 specfiles checked; 0 errors, 17 warnings.

=> harmless

+ Source verified with upstream as 
  CHECKSUM(SHA256) this package     : 08335c4ef0bbe8b8df8be667fcecf8db603ba01f493748a6a49c95946fae5fb4
  CHECKSUM(SHA256) upstream package : 08335c4ef0bbe8b8df8be667fcecf8db603ba01f493748a6a49c95946fae5fb4

+ License is valid, BSD and its text is included in COPYING

+ package follows packaging guidelines

APPROVED.

Comment 4 Daiki Ueno 2013-02-01 06:46:02 UTC
New Package SCM Request
=======================
Package Name: marisa
Short Description: static and spece-efficient trie data structure library
Owners: ueno
Branches: f18 f17
InitialCC:

Comment 5 Gwyn Ciesla 2013-02-01 13:46:13 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-02-04 02:51:27 UTC
marisa-0.2.1-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/marisa-0.2.1-2.fc18

Comment 7 Fedora Update System 2013-02-04 02:51:44 UTC
marisa-0.2.1-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/marisa-0.2.1-2.fc17

Comment 8 Fedora Update System 2013-02-11 23:32:17 UTC
marisa-0.2.1-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/marisa-0.2.1-3.fc18

Comment 9 Fedora Update System 2013-02-11 23:33:19 UTC
marisa-0.2.1-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/marisa-0.2.1-3.fc17

Comment 10 Fedora Update System 2013-02-12 02:08:56 UTC
ibus-kkc-1.5.6-1.fc18, marisa-0.2.1-3.fc18, libkkc-0.1.5-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/marisa-0.2.1-3.fc18,libkkc-0.1.5-1.fc18,ibus-kkc-1.5.6-1.fc18

Comment 11 Fedora Update System 2013-02-12 02:15:35 UTC
ibus-kkc-1.5.6-1.fc17, marisa-0.2.1-3.fc17, libkkc-0.1.5-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/marisa-0.2.1-3.fc17,libkkc-0.1.5-1.fc17,ibus-kkc-1.5.6-1.fc17

Comment 12 Fedora Update System 2013-02-23 00:52:10 UTC
ibus-kkc-1.5.6-1.fc18, marisa-0.2.1-3.fc18, libkkc-0.1.5-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 13 Fedora Update System 2013-02-23 01:04:38 UTC
ibus-kkc-1.5.6-1.fc17, marisa-0.2.1-3.fc17, libkkc-0.1.5-1.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.