Bug 906913

Summary:	ppp radius plugin breaks on new keywords in radius config file
Product:	[Fedora] Fedora	Reporter:	Charlie Brady <charlieb-redhat-bugzilla>
Component:	ppp	Assignee:	Michal Sekletar <msekleta>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	18	CC:	jsynacek, msekleta, thozza
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ppp-2.4.5-29.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	906912	Environment:
Last Closed:	2013-06-07 04:34:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Charlie Brady 2013-02-01 21:55:41 UTC

+++ This bug was initially created as a clone of Bug #906912 +++

Created attachment 691752 [details]
Patch to skip unrecognised directives when parsing radius file

If ppp is configured to use the radius plugin for authentication:

...
plugin radius.so
radius-config-file /etc/radiusclient-ng/radiusclient.conf
...

and radiusclient.conf contains 'bindaddr *' (as it does in radiusclient-ng-0.5.6-8.fc18.i686.rpm), then: authentication fails with these log messages:

> Nov 23 10:46:11 vucc2 pppd[1171]: /etc/radiusclient-ng/radiusclient.conf: line 75: unrecognized
> keyword: bindaddr
> Nov 23 10:46:11 vucc2 pppd[1171]: RADIUS: Can't read config file
> /etc/radiusclient-ng/radiusclient.conf 

The problem is that the config file parser in the radius plugin of pppd is too strict. Instead of ignoring configuration directives that it does not recognise, and does not care about, it stops parsing the file, and returns an error, and remains itself unconfigured.

Patch attached.

--- Additional comment from Charlie Brady on 2013-02-01 16:54:41 EST ---

Patch was long ago submitted to linux-ppp mailing list, but that list appears to be unmonitored by the ppp maintainers.

http://marc.info/?l=linux-ppp&m=134636974704703

Comment 1 Michal Sekletar 2013-03-19 18:41:50 UTC

Thank you for the bug report and linked patch. I am planing to do the release of ppp in Fedora soon. I will apply the patch, since it looks like it can't break anything.

Comment 2 Fedora Update System 2013-05-29 12:21:01 UTC

ppp-2.4.5-29.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ppp-2.4.5-29.fc19

Comment 3 Fedora Update System 2013-05-29 17:44:40 UTC

Package ppp-2.4.5-29.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ppp-2.4.5-29.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-9554/ppp-2.4.5-29.fc19
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-06-07 04:34:10 UTC

ppp-2.4.5-29.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.