Bug 908357 (Horde_Xml_Wbxml)
| Summary: | Review Request: php-horde-Horde-Xml-Wbxml - Provides an API for encoding and decoding WBXML documents | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | nb, notting, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-02-27 18:02:23 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 785439, 785606 | ||||||||
| Bug Blocks: | 927894 | ||||||||
| Attachments: |
|
||||||||
|
Description
Remi Collet
2013-02-06 13:59:44 UTC
*** Bug 785481 has been marked as a duplicate of this bug. *** Created attachment 695663 [details] php-horde-Horde-Xml-Wbxml-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 908357 Created attachment 695664 [details]
phpci.log
Couldn't the "> 12" be removed from "%if 0%{?fedora} > 12"? Or even just changed to "%{?fedora:BuildRequires: libwbxml}"?
===== MUST items =====
[!]: Requires correct, justified where necessary.
phpci: pcre, xml
Missing requires: https://github.com/remicollet/remirepo/commit/9c61bb7e79ed70782d80b537174436c55b3b1ded > Couldn't the "> 12" be removed ... I prefer to keep it (which makle backport easier) and because I don't know yet if this package will be available in RHEL-7, so could become %if 0%{?fedora} > 12 || 0%{?rhel} > 6 Spec: https://raw.github.com/remicollet/remirepo/9c61bb7e79ed70782d80b537174436c55b3b1ded/php/horde/php-horde-Horde-Xml-Wbxml/php-horde-Horde-Xml-Wbxml.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Xml-Wbxml-2.0.1-3.remi.src.rpm [!]: Requires correct, justified where necessary. => FIXED No blockers. ===== APPROVED ===== Thanks for the review New Package SCM Request ======================= Package Name: php-horde-Horde-Xml-Wbxml Short Description: Provides an API for encoding and decoding WBXML documents Owners: remi nb Branches: f18 el6 InitialCC: Git done (by process-git-requests). php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18 php-horde-Horde-Xml-Wbxml-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Xml-Wbxml-2.0.1-3.el6 php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18 has been pushed to the Fedora 18 testing repository. php-horde-Horde-Xml-Wbxml-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18 has been pushed to the Fedora 18 stable repository. |