Spec URL: https://raw.github.com/remicollet/remirepo/b69168c4009c02177e92b5c3e77f5273df5e487b/php/horde/php-horde-Horde-Xml-Wbxml/php-horde-Horde-Xml-Wbxml.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Xml-Wbxml-2.0.1-2.remi.src.rpm Description: Fedora Account System Username: remi
*** Bug 785481 has been marked as a duplicate of this bug. ***
Created attachment 695663 [details] php-horde-Horde-Xml-Wbxml-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 908357
Created attachment 695664 [details] phpci.log
Couldn't the "> 12" be removed from "%if 0%{?fedora} > 12"? Or even just changed to "%{?fedora:BuildRequires: libwbxml}"? ===== MUST items ===== [!]: Requires correct, justified where necessary. phpci: pcre, xml
Missing requires: https://github.com/remicollet/remirepo/commit/9c61bb7e79ed70782d80b537174436c55b3b1ded > Couldn't the "> 12" be removed ... I prefer to keep it (which makle backport easier) and because I don't know yet if this package will be available in RHEL-7, so could become %if 0%{?fedora} > 12 || 0%{?rhel} > 6 Spec: https://raw.github.com/remicollet/remirepo/9c61bb7e79ed70782d80b537174436c55b3b1ded/php/horde/php-horde-Horde-Xml-Wbxml/php-horde-Horde-Xml-Wbxml.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Xml-Wbxml-2.0.1-3.remi.src.rpm
[!]: Requires correct, justified where necessary. => FIXED No blockers. ===== APPROVED =====
Thanks for the review New Package SCM Request ======================= Package Name: php-horde-Horde-Xml-Wbxml Short Description: Provides an API for encoding and decoding WBXML documents Owners: remi nb Branches: f18 el6 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18
php-horde-Horde-Xml-Wbxml-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Xml-Wbxml-2.0.1-3.el6
php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18 has been pushed to the Fedora 18 testing repository.
php-horde-Horde-Xml-Wbxml-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
php-horde-Horde-Xml-Wbxml-2.0.1-3.fc18 has been pushed to the Fedora 18 stable repository.