|Product:||[Fedora] Fedora||Reporter:||Jamie Nguyen <jamielinux>|
|Component:||Package Review||Assignee:||T.C. Hollingsworth <tchollingsworth>|
|Status:||CLOSED ERRATA||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Version:||rawhide||CC:||notting, package-review, tchollingsworth|
|Fixed In Version:||nodejs-dep-graph-1.1.0-2.fc19||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2013-06-18 05:41:56 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Cloudforms Team:||---||Target Upstream Version:|
|Bug Depends On:||911055|
|Bug Blocks:||956806, 911050|
Description Jamie Nguyen 2013-02-14 09:35:21 UTC
Comment 1 T.C. Hollingsworth 2013-06-14 01:51:55 UTC
Comment 2 T.C. Hollingsworth 2013-06-14 01:57:05 UTC
Wait, I didn't notice the coffee-script building was conditionalized on tests being enabled. Please do this unconditionally, it's necessary to comply to the Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries Sorry, review approval rescinded. This package NEEDS WORK.
Comment 3 Jamie Nguyen 2013-06-16 13:51:39 UTC
Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-dep-graph.spec SRPM URL: http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-dep-graph-1.1.0-2.fc19.src.rpm * Sun Jun 16 2013 Jamie Nguyen <email@example.com> - 1.1.0-2 - unconditionalize 'cake build' - improve Summary
Comment 4 T.C. Hollingsworth 2013-06-16 14:07:10 UTC
Still builds in mock fine with `cake build` enabled, so APPROVED.
Comment 5 Jamie Nguyen 2013-06-16 15:05:27 UTC
Comment 6 Gwyn Ciesla 2013-06-17 12:19:04 UTC
Git done (by process-git-requests).
Comment 7 Fedora Update System 2013-06-18 05:35:28 UTC
nodejs-dep-graph-1.1.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-dep-graph-1.1.0-2.fc19
Comment 8 Fedora Update System 2013-06-18 05:36:43 UTC
nodejs-dep-graph-1.1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-dep-graph-1.1.0-2.fc18
Comment 9 Fedora Update System 2013-06-28 06:13:49 UTC
nodejs-dep-graph-1.1.0-2.fc18 has been pushed to the Fedora 18 stable repository.
Comment 10 Fedora Update System 2013-06-29 18:50:45 UTC
nodejs-dep-graph-1.1.0-2.fc19 has been pushed to the Fedora 19 stable repository.