Bug 911055 - Review Request: nodejs-underscore - JavaScript's functional programming helper library
Summary: Review Request: nodejs-underscore - JavaScript's functional programming helpe...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Tom Hughes
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 911029 911050
TreeView+ depends on / blocked
Reported: 2013-02-14 09:50 UTC by Jamie Nguyen
Modified: 2013-04-07 00:29 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-03-19 14:09:51 UTC
Type: ---
tom: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jamie Nguyen 2013-02-14 09:50:49 UTC
Spec URL: http://jamielinux.fedorapeople.org/buddycloud-server/nodejs-underscore.spec
SRPM URL:http://jamielinux.fedorapeople.org/buddycloud-server/SRPMS/nodejs-underscore-1.4.4-1.fc18.src.rpm
Fedora Account System Username: jamielinux

Underscore.js is a utility-belt library for JavaScript that provides support
for the usual functional suspects (each, map, reduce, filter...) without
extending any core JavaScript objects.

Comment 1 Tom Hughes 2013-02-18 22:48:06 UTC
Package Review

[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

[!]: SourceX / PatchY prefixed with %{name}.
     Should Source1 and Source10 be prefixed?

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 102400 bytes in 5 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Source0 (underscore-1.4.4.tgz) Source1 (tests-1.4.4.tar.bz2)
     Source10 (dl-tests.sh)
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is

Checking: nodejs-underscore-1.4.4-1.fc19.src.rpm
nodejs-underscore.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-underscore.src: W: strange-permission dl-tests.sh 0755L
nodejs-underscore.src: W: invalid-url Source1: tests-1.4.4.tar.bz2
nodejs-underscore.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-underscore.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Rpmlint (installed packages)
# rpmlint nodejs-underscore
nodejs-underscore.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-underscore.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

nodejs-underscore-1.4.4-1.fc19.noarch.rpm (rpmlib, GLIBC filtered):

    nodejs-underscore = 1.4.4-1.fc19
    npm(underscore) = 1.4.4

MD5-sum check
http://registry.npmjs.org/underscore/-/underscore-1.4.4.tgz :
  CHECKSUM(SHA256) this package     : a848a28193850d58d7b98249d70844bc7f35a7d8b6b5ed75e08e829aa6e763d3
  CHECKSUM(SHA256) upstream package : a848a28193850d58d7b98249d70844bc7f35a7d8b6b5ed75e08e829aa6e763d3

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 911055

Comment 2 Jamie Nguyen 2013-02-20 08:35:33 UTC
Thanks for the review!

[!]: SourceX / PatchY prefixed with %{name}.
     Should Source1 and Source10 be prefixed?

I couldn't find anything in guidelines about this, nor in the review guidelines. Is it actually necessary? I'll need to change for some packages that have already been approved too.

Comment 3 Tom Hughes 2013-02-20 09:17:09 UTC
I agree - there doesn't seem to be anything about that in the packaging or review guidelines and I know that while it is common there are certainly plenty of packages without prefixes.

On that basis, package approved.

Comment 4 Jamie Nguyen 2013-02-20 09:18:50 UTC
New Package SCM Request
Package Name: nodejs-underscore
Short Description: JavaScript's functional programming helper library
Owners: jamielinux
Branches: f18 el6

Comment 5 Gwyn Ciesla 2013-02-20 13:20:32 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2013-02-21 09:24:11 UTC
nodejs-underscore-1.4.4-1.fc18 has been submitted as an update for Fedora 18.

Comment 7 Fedora Update System 2013-02-23 01:00:27 UTC
nodejs-underscore-1.4.4-1.fc18 has been pushed to the Fedora 18 testing repository.

Comment 8 Fedora Update System 2013-04-07 00:29:31 UTC
nodejs-underscore-1.4.4-1.fc18 has been pushed to the Fedora 18 stable repository.

Note You need to log in before you can comment on or make changes to this bug.