Bug 911781 (bittwist)

Hi Giuseppe 

About review process

Perhaps you have tried to register at any time when the platform was not available, however, and the expectation that you are searching a different url, you retry with this.

https://admin.fedoraproject.org/accounts/

These links may be useful:
- https://fedoraproject.org/wiki/Package_Review_Process#Contributor
- https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Use_rpmlint

Is good practice paste the rpmlint output in the review, and at least make a build scratch on koji and paste the link in the review

https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds

Please tag the field "Blocks" with the word FE-NEEDSPONSOR. So, will let you know the sponsors you need sponsorship  

About the package 

I have not thoroughly checked the package, but at first glance,  I give some recommendations

You have a typo in this line
URL:		http://http://bittwist.sourceforge.net/

in %install
make install prefix=${RPM_BUILD_ROOT}/usr
should be 
make install DESTDIR=%{buildroot} PREFIX=%{_prefix}

(if $DESTDIR supports)

Check it
$ rpm --eval %{_prefix}
/usr

the description should not be more than 80 characters per line, rpmlit complains with description-line-too-long

- Please do honors applicable compiler flags, Use %{optflags}

Check it
$ rpm --eval %{optflags}
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic


Check the makefile and do the patch, (do not forget to send the patch to upstream)

bittwist:
        $(CC) $(CFLAGS) $(SRC)/bittwist.c -o $(SRC)/bittwist -I/usr/local/include -L/usr/local/lib -lpcap

bittwiste:
        $(CC) $(CFLAGS) $(SRC)/bittwiste.c -o $(SRC)/bittwiste -I/usr/local/include -L/usr/local/lib -lpcap

- the tag license is wrong 
License:	GPL2
should be
License:        GPLv2

the changelog is wrong
%changelog
* Fri Feb 15 2013 Giuseppe Marco Randazzo <gmrandazzo>
- first build for bittwist
should be
%changelog
* Fri Feb 15 2013 Giuseppe Marco Randazzo <gmrandazzo> - 2.0-1
- first build for bittwist

https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

- Don't needed %defattr(-,root,root)

Kind Regards

Giuseppe, are you still interested to go on with this package?

Giuseppe?

Hello, yes i am still interested.... sorry for the delay!! :-) Here all the modifications!! I hope now the spec file and the patch are fine!

Thanks!!

Giuseppe Marco Randazzo

Created attachment 911551 [details]
bittwist new spec file

New Bitwist spec file

Created attachment 911552 [details]
bittwist-Makefile patch

The bittwist-Makefile patch.


~ Added the DESTDIR support
~ Fixed the make procedure to use the optflags

Can you please provide updated files (spec and SRPM)? Thanks.

Created attachment 918154 [details]
bittwist-2.0-2 SRC RPM  2014-07-15

SRC RPM bittwist 2.0-2

Created attachment 918155 [details]
bittwist spec file 2014-07-15

bittwist spec file 2014-07-15

Created attachment 918156 [details]
bittwist Make file patch 2014-07-15

bittwist 2.0-2 Make file patch 2014-07-15

Can you please provide updated files (spec and SRPM)? Not as attachment to the report but rather as links. Thanks.

I'm still interested in know what is the fas of Giuseppe and if still he hasn't been sponsored. Like says Fabian, Giuseppe, please append the links of the spec and SRPM, usually reviewers use a tool named fedora-review, that expects those links be available at the review.

Dear all,

thank you for your support and interest.
I found a workaround package, tcpreply.
With this message I would like to close this package request.

Best regards,
GMR

You mean tcpreplay https://src.fedoraproject.org/rpms/tcpreplay