Bug 911911

Summary: Review Request: perl-Import-Into - Import packages into other packages
Product: [Fedora] Fedora Reporter: Iain Arnell <iarnell>
Component: Package ReviewAssignee: Emmanuel Seyman <emmanuel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: emmanuel, notting, package-review, ppisar
Target Milestone: ---Flags: emmanuel: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-28 07:02:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 912066, 912132    

Description Iain Arnell 2013-02-16 17:06:43 UTC
Spec URL: http://iarnell.fedorapeople.org/review/perl-Import-Into.spec
SRPM URL: http://iarnell.fedorapeople.org/review/perl-Import-Into-1.001000-1.fc19.src.rpm
Loading Import::Into creates a global method import::into which you can call on
any package to import it into another package.

Fedora Account System Username: iarnell

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=4999947

Comment 1 Emmanuel Seyman 2013-02-17 19:01:25 UTC

Comment 2 Iain Arnell 2013-02-17 19:54:14 UTC
CCing Petr as I've just noticed this is a dupe of #911174.

Comment 3 Emmanuel Seyman 2013-02-17 20:18:17 UTC
=== KEY ===

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated


 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5014453

 [x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
Not specified, default used.

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
84577f9469c5bf007c4537a67dda3813  Import-Into-1.001000.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] Package does not own files or directories owned by other packages.


 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5014453
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.02 cusr  0.01 csys =  0.07 CPU)
Result: PASS


Comment 4 Iain Arnell 2013-02-17 20:25:02 UTC
New Package SCM Request
Package Name: perl-Import-Into
Short Description: Import packages into other packages
Owners: iarnell ppisar
Branches: F17 F18
InitialCC: perl-sig

Comment 5 Iain Arnell 2013-02-17 20:33:31 UTC
*** Bug 911174 has been marked as a duplicate of this bug. ***

Comment 6 Gwyn Ciesla 2013-02-18 14:47:02 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-02-18 19:29:55 UTC
perl-Import-Into-1.001000-1.fc18 has been submitted as an update for Fedora 18.

Comment 8 Fedora Update System 2013-02-18 19:30:05 UTC
perl-Import-Into-1.001000-1.fc17 has been submitted as an update for Fedora 17.

Comment 9 Fedora Update System 2013-02-20 03:54:18 UTC
perl-Import-Into-1.001000-1.fc18 has been pushed to the Fedora 18 testing repository.

Comment 10 Fedora Update System 2013-02-28 07:02:28 UTC
perl-Import-Into-1.001000-1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 11 Fedora Update System 2013-02-28 07:09:46 UTC
perl-Import-Into-1.001000-1.fc17 has been pushed to the Fedora 17 stable repository.