Spec URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant.spec SRPM URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant-1.001002-1.fc17.src.rpm Description: http://iarnell.fedorapeople.org/review/perl-Package-Variant-1.001002-1.fc17.src.rpm Fedora Account System Username: iarnell
Oops. Description: This module allows you to build packages that return different variations depending on what parameters are given.
Now that perl-Import-Into is available, there's a scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=5027195
You're missing a build-time dependency, perl(Sub::Name). Required at lib/Package/Variant.pm:53. This gets called in t/11dynamic-build.t It also isn't detected by rpmbuild while the package users will most likely want it. The rest of the package looks good.
Thanks, Petr. I've added R/BR for perl(Sub::Name). Spec URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant.spec SRPM URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant-1.001002-2.fc19.src.rpm New scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=5036574
Splendid. Approving.
New Package SCM Request ======================= Package Name: perl-Package-Variant Short Description: Parameterizable packages Owners: iarnell Branches: F17 F18 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Package-Variant-1.001002-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Package-Variant-1.001002-2.fc17
perl-Package-Variant-1.001002-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Package-Variant-1.001002-2.fc18
perl-Package-Variant-1.001002-2.fc17 has been pushed to the Fedora 17 testing repository.
perl-Package-Variant-1.001002-2.fc17 has been pushed to the Fedora 17 stable repository.
perl-Package-Variant-1.001002-2.fc18 has been pushed to the Fedora 18 stable repository.