Bug 912305

Summary: Move fkvalidator.sh to tools/dbutils
Product: Red Hat Enterprise Virtualization Manager Reporter: Eli Mesika <emesika>
Component: ovirt-engineAssignee: Eli Mesika <emesika>
Status: CLOSED CURRENTRELEASE QA Contact: Ilanit Stein <istein>
Severity: high Docs Contact:
Priority: high    
Version: 3.2.0CC: acathrow, dyasny, iheim, italkohe, lpeer, mgoldboi, pstehlik, Rhev-m-bugs, yeylon, ykaul, yzaslavs
Target Milestone: ---Keywords: ZStream
Target Release: 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: sf9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 915925 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 893459, 915925, 917401    

Description Eli Mesika 2013-02-18 11:04:17 UTC
Description of problem:
Since  fkvalidator.sh should be run in the pre-upgrade step of the installer. It must be moved to tools/dbutils because the dbscripts RPM is copied after the pre-upgrade step

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1.
2.
3.
  
Actual results:
 fkvalidator.sh is under sbscripts

Expected results:

 fkvalidator.sh should be moved to tools/dbutils

Additional info:

Comment 1 Eli Mesika 2013-02-20 08:28:31 UTC
fixed in commit : bd0a4f8

Comment 2 Eli Mesika 2013-02-20 09:37:47 UTC
fixed in commit : 93152a5 (missing file)

Comment 5 Eli Mesika 2013-02-27 10:36:39 UTC
reopened

Reason : fkvalidator uses SPs that should also be moved to the tools/dbscripts directory

Since the fkvalidator is used from the installer in the pre-upgrade step, it will fail if those SPs are not found

Comment 7 Ilanit Stein 2013-03-07 10:10:04 UTC
Comment from https://bugzilla.redhat.com/show_bug.cgi?id=915925, from which this bug was cloned:

"Yair Zaslavsky 2013-03-04 11:14:26 EST
The complete commit message includes - 
Creating a common.sh for common environment settings of all tools.
What matters in this bug, and the fact it was inserted to 3.1.3 is the above part - the creation of common.sh script and usage of it in taskcleaner.sh
This is a code change, although it can be easily be browsed by looking for common.sh and looing at taskcleaner.sh"

Verified on sf-9, following this comment.

Comment 8 Itamar Heim 2013-06-11 08:57:41 UTC
3.2 has been released

Comment 9 Itamar Heim 2013-06-11 08:57:44 UTC
3.2 has been released

Comment 10 Itamar Heim 2013-06-11 08:57:47 UTC
3.2 has been released

Comment 11 Itamar Heim 2013-06-11 08:59:50 UTC
3.2 has been released

Comment 12 Itamar Heim 2013-06-11 09:29:22 UTC
3.2 has been released