Bug 912305 - Move fkvalidator.sh to tools/dbutils
Summary: Move fkvalidator.sh to tools/dbutils
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.2.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 3.2.0
Assignee: Eli Mesika
QA Contact: Ilanit Stein
URL:
Whiteboard: infra
Depends On:
Blocks: 893459 915925 917401
TreeView+ depends on / blocked
 
Reported: 2013-02-18 11:04 UTC by Eli Mesika
Modified: 2016-02-10 19:10 UTC (History)
11 users (show)

Fixed In Version: sf9
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 915925 (view as bug list)
Environment:
Last Closed:
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 12172 0 None None None Never
oVirt gerrit 12225 0 None None None Never
oVirt gerrit 12492 0 None None None Never

Description Eli Mesika 2013-02-18 11:04:17 UTC
Description of problem:
Since  fkvalidator.sh should be run in the pre-upgrade step of the installer. It must be moved to tools/dbutils because the dbscripts RPM is copied after the pre-upgrade step

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1.
2.
3.
  
Actual results:
 fkvalidator.sh is under sbscripts

Expected results:

 fkvalidator.sh should be moved to tools/dbutils

Additional info:

Comment 1 Eli Mesika 2013-02-20 08:28:31 UTC
fixed in commit : bd0a4f8

Comment 2 Eli Mesika 2013-02-20 09:37:47 UTC
fixed in commit : 93152a5 (missing file)

Comment 5 Eli Mesika 2013-02-27 10:36:39 UTC
reopened

Reason : fkvalidator uses SPs that should also be moved to the tools/dbscripts directory

Since the fkvalidator is used from the installer in the pre-upgrade step, it will fail if those SPs are not found

Comment 7 Ilanit Stein 2013-03-07 10:10:04 UTC
Comment from https://bugzilla.redhat.com/show_bug.cgi?id=915925, from which this bug was cloned:

"Yair Zaslavsky 2013-03-04 11:14:26 EST
The complete commit message includes - 
Creating a common.sh for common environment settings of all tools.
What matters in this bug, and the fact it was inserted to 3.1.3 is the above part - the creation of common.sh script and usage of it in taskcleaner.sh
This is a code change, although it can be easily be browsed by looking for common.sh and looing at taskcleaner.sh"

Verified on sf-9, following this comment.

Comment 8 Itamar Heim 2013-06-11 08:57:41 UTC
3.2 has been released

Comment 9 Itamar Heim 2013-06-11 08:57:44 UTC
3.2 has been released

Comment 10 Itamar Heim 2013-06-11 08:57:47 UTC
3.2 has been released

Comment 11 Itamar Heim 2013-06-11 08:59:50 UTC
3.2 has been released

Comment 12 Itamar Heim 2013-06-11 09:29:22 UTC
3.2 has been released


Note You need to log in before you can comment on or make changes to this bug.