Bug 912946
| Summary: | gluster error while generating sosreport in RHEL 6.4. | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Gowrishankar Rajaiyan <grajaiya> |
| Component: | sos | Assignee: | Shane Bradley <sbradley> |
| Status: | CLOSED ERRATA | QA Contact: | Miroslav Hradílek <mhradile> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.4 | CC: | agk, bmr, chorn, dkutalek, gavin, grajaiya, mhradile, ndevos, plambri, pmoravec, rhs-bugs, rwheeler, sbradley, vagarwal, vbellur |
| Target Milestone: | pre-dev-freeze | ||
| Target Release: | 6.7 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | sos-3.2-16.el6 | Doc Type: | Bug Fix |
| Doc Text: |
The "glusterfsd: no process killed" message could previously be displayed in the standard output stream when generating a report. This update modifies the gluster plug-in to use the built-in callout functions, and the message is no longer displayed in this situation.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-22 06:32:42 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gowrishankar Rajaiyan
2013-02-20 03:32:51 UTC
RaBhat, can we do 'ps aux| grep glusterfs| grep -v grep' to check the process is running before issuing the signal? Better to use pgrep/pkill - we try to avoid launching pipelines from sos (or simply suppress the error from the attempted kill). This happens because the gluster plugin decided to roll its own callout mechanism:
#self.collectExtOutput("killall -USR1 glusterfs glusterfsd")
os.system("killall -USR1 glusterfs glusterfsd");
Don't do that: use the already provided PluginBase APIs:
callExtProg()
collectExtOutput()
collectOutputNow()
In this instance the first is probably correct since the plugin doesn't care about storing the output in the report.
self.callExtProg("killall -USR1 glusterfs glusterfsd")
Should do what you want.
I've fixed this upstream on master:
commit adc1be1ecab468aed5dbac64b7b7d1ce0cc92180
Author: Bryn M. Reeves <bmr>
Date: Tue Apr 8 13:48:40 2014 +0100
Replace os.system() in gluster plugin with self.check_ext_prog()
Plugins should not open-code calls to external commands. Use the
build-in check_ext_prog() interface instead and test for success
before attempting to collect the statedump files.
Signed-off-by: Bryn M. Reeves <bmr>
The RHEL6 version will be slightly different as we don't currently have checkExtProg(). We can either backport that (trivial) or adapt the gluster change to use callExtProg() and check the returned status.
A partner reports the glusterfs: no process killed glusterfsd: no process killed on a rhel6.6beta. I am irritated that this bz is for 6.4, yet component was set to RHS. Should the component be changed, or a different bz be opened? Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1323.html |