Bug 913004

Summary:	Review Request: perl-re-engine-RE2 - RE2 regex engine
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <bochecha>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-03-07 06:27:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mathieu Bridon 2013-02-20 08:09:19 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2-0.11-1.fc19.src.rpm

Description:
This module replaces perl's regex engine in a given lexical scope with RE2.

Fedora Account System Username: bochecha

Comment 1 Mathieu Bridon 2013-02-21 04:43:08 UTC

I made a couple of adjustments, so here is the new submission.

Spec URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2-0.11-2.fc19.src.rpm

Comment 2 Petr Šabata 2013-03-05 13:48:39 UTC

Ok, no issues with your package.

Perhaps doing plain "rm -r re2" in %prep would make the patch more readable.  Just a personal opinion.

Approving.

Comment 3 Mathieu Bridon 2013-03-06 04:25:49 UTC

(In reply to comment #2)
> Ok, no issues with your package.

Wait, I didn't forget any BuildRequires this time? \o/

> Perhaps doing plain "rm -r re2" in %prep would make the patch more readable.
> Just a personal opinion.

I thought about that, but I like the idea of just applying patches and nothing else in the spec file, as much as possible.

Also, it feels weird to patch the MANIFEST so it doesn't include the re2 folder anymore, while the folder itself is removed outside of the patch.

But yeah, it does make a world of difference concerning the readability of the patch, which is very important for something like that (unbundling can be tricky, I'd be happier if others can review the patch, so I should do what I can to make that easier).

So I'll change that when importing the package.

> Approving.

Thanks Petr!

New Package SCM Request
=======================
Package Name: perl-re-engine-RE2
Short Description: RE2 regex engine
Owners: bochecha
Branches: devel
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2013-03-06 13:37:27 UTC

Git done (by process-git-requests).

Comment 5 Mathieu Bridon 2013-03-07 06:27:01 UTC

Thanks for the Git process Jon.

Package built in Rawhide, closing.