Spec URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2-0.11-1.fc19.src.rpm Description: This module replaces perl's regex engine in a given lexical scope with RE2. Fedora Account System Username: bochecha
I made a couple of adjustments, so here is the new submission. Spec URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-re-engine-RE2-0.11-2.fc19.src.rpm
Ok, no issues with your package. Perhaps doing plain "rm -r re2" in %prep would make the patch more readable. Just a personal opinion. Approving.
(In reply to comment #2) > Ok, no issues with your package. Wait, I didn't forget any BuildRequires this time? \o/ > Perhaps doing plain "rm -r re2" in %prep would make the patch more readable. > Just a personal opinion. I thought about that, but I like the idea of just applying patches and nothing else in the spec file, as much as possible. Also, it feels weird to patch the MANIFEST so it doesn't include the re2 folder anymore, while the folder itself is removed outside of the patch. But yeah, it does make a world of difference concerning the readability of the patch, which is very important for something like that (unbundling can be tricky, I'd be happier if others can review the patch, so I should do what I can to make that easier). So I'll change that when importing the package. > Approving. Thanks Petr! New Package SCM Request ======================= Package Name: perl-re-engine-RE2 Short Description: RE2 regex engine Owners: bochecha Branches: devel InitialCC: perl-sig
Git done (by process-git-requests).
Thanks for the Git process Jon. Package built in Rawhide, closing.