Bug 914631 (PM-315, PRODMGT-315)

Summary: RFE: Allow editing of existing alert condition within an alert definition
Product: [JBoss] JBoss Operations Network Reporter: Jirka Kremser <jkremser>
Component: Monitoring - AlertsAssignee: Jirka Kremser <jkremser>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: JON 3.1.2CC: hrupp, loleary
Target Milestone: ER03   
Target Release: JON 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jirka Kremser 2013-02-22 10:58:47 UTC
Description of problem:
Based on https://issues.jboss.org/browse/PRODMGT-315
There should be a way to modify an existing alert condition. Removing the old one and adding a new one is not convenient for users. We should provide a button ("Edit" / "Modify") in UI for allowing it.


Version-Release number of selected component (if applicable):
4.6.0-SNAPSHOT

How reproducible:
always

Comment 1 Heiko W. Rupp 2013-02-22 11:04:11 UTC
Only adding a button is not enough, as the underlying mechanism does not yet allow to edit the condition object (the object itself is replaced by a different one ).I was facing that issue in the REST api as well.
See org.rhq.enterprise.server.rest.AlertDefinitionHandlerBean#updateCondition

Comment 2 Jirka Kremser 2013-03-04 13:38:17 UTC
I suggest adding a new method to AlertDefinitionManager and then reuse it from the AlertDefinitionHandlerBean#updateCondition not to replicate the code. The AlertDefinitionHandlerBean has already the reference for the AlertDefinitionManager, so there will be only small change there. I have to still investigate how the history of changes to the definitions will be handled.

Comment 3 Jirka Kremser 2013-03-12 17:41:24 UTC
master
5adfb9631
f9a6b22f3
9c2e41ff6
b0115d6fe
58a547f70
09236848d
b006ad62d
5cd41a121

Comment 6 Heiko W. Rupp 2013-08-08 13:57:34 UTC
This is in the latest brew build