Bug 914631 (PM-315, PRODMGT-315) - RFE: Allow editing of existing alert condition within an alert definition
Summary: RFE: Allow editing of existing alert condition within an alert definition
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: PM-315, PRODMGT-315
Product: JBoss Operations Network
Classification: JBoss
Component: Monitoring - Alerts
Version: JON 3.1.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ER03
: JON 3.2.0
Assignee: Jirka Kremser
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-02-22 10:58 UTC by Jirka Kremser
Modified: 2018-12-03 18:20 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: Feature Request
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker PRODMGT-315 0 Major Closed Allow editing of existing alert condition within an alert definition 2014-05-29 06:40:49 UTC

Description Jirka Kremser 2013-02-22 10:58:47 UTC
Description of problem:
Based on https://issues.jboss.org/browse/PRODMGT-315
There should be a way to modify an existing alert condition. Removing the old one and adding a new one is not convenient for users. We should provide a button ("Edit" / "Modify") in UI for allowing it.


Version-Release number of selected component (if applicable):
4.6.0-SNAPSHOT

How reproducible:
always

Comment 1 Heiko W. Rupp 2013-02-22 11:04:11 UTC
Only adding a button is not enough, as the underlying mechanism does not yet allow to edit the condition object (the object itself is replaced by a different one ).I was facing that issue in the REST api as well.
See org.rhq.enterprise.server.rest.AlertDefinitionHandlerBean#updateCondition

Comment 2 Jirka Kremser 2013-03-04 13:38:17 UTC
I suggest adding a new method to AlertDefinitionManager and then reuse it from the AlertDefinitionHandlerBean#updateCondition not to replicate the code. The AlertDefinitionHandlerBean has already the reference for the AlertDefinitionManager, so there will be only small change there. I have to still investigate how the history of changes to the definitions will be handled.

Comment 3 Jirka Kremser 2013-03-12 17:41:24 UTC
master
5adfb9631
f9a6b22f3
9c2e41ff6
b0115d6fe
58a547f70
09236848d
b006ad62d
5cd41a121

Comment 6 Heiko W. Rupp 2013-08-08 13:57:34 UTC
This is in the latest brew build


Note You need to log in before you can comment on or make changes to this bug.