Bug 914704

Summary: udpcast-20120424-4 has -s in LDFLAGS
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: udpcastAssignee: Ville Skyttä <ville.skytta>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: rjones
Target Milestone: ---Keywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: udpcast-20120424-5.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-22 15:59:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 496968    

Description Ville Skyttä 2013-02-22 15:01:15 UTC 
udpcast-20120424-4 has -s in LDFLAGS again, Makefile.in has changed so that the sed in the specfile no longer does its job. While fixing it, I suggest converting that stuff to a patch so it's less likely to break silently in the future.

Also while at it, Makefile.in adds -O6 to CFLAGS which is bogus anyway, and the rationale for doing/allowing that should be documented in the specfile.
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
Comment 1 Richard W.M. Jones 2013-02-22 15:19:40 UTC 
If I'm reading the man page right, '-s' in LDFLAGS will
strip the binary, which obviously we don't want to do
because debuginfo will be empty.

Do you want to just make these changes?
Comment 2 Ville Skyttä 2013-02-22 15:30:46 UTC 
Sure, can do.
Comment 3 Ville Skyttä 2013-02-22 15:59:43 UTC 
http://pkgs.fedoraproject.org/cgit/udpcast.git/commit/?id=2aa71e8
(Took the liberty to make a few other cosmetic changes while at it.)