Bug 914704 - udpcast-20120424-4 has -s in LDFLAGS
Summary: udpcast-20120424-4 has -s in LDFLAGS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: udpcast
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DebugInfo
TreeView+ depends on / blocked
 
Reported: 2013-02-22 15:01 UTC by Ville Skyttä
Modified: 2013-02-22 15:59 UTC (History)
1 user (show)

Fixed In Version: udpcast-20120424-5.fc19
Clone Of:
Environment:
Last Closed: 2013-02-22 15:59:43 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Ville Skyttä 2013-02-22 15:01:15 UTC 
udpcast-20120424-4 has -s in LDFLAGS again, Makefile.in has changed so that the sed in the specfile no longer does its job. While fixing it, I suggest converting that stuff to a patch so it's less likely to break silently in the future.

Also while at it, Makefile.in adds -O6 to CFLAGS which is bogus anyway, and the rationale for doing/allowing that should be documented in the specfile.
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
Comment 1 Richard W.M. Jones 2013-02-22 15:19:40 UTC 
If I'm reading the man page right, '-s' in LDFLAGS will
strip the binary, which obviously we don't want to do
because debuginfo will be empty.

Do you want to just make these changes?
Comment 2 Ville Skyttä 2013-02-22 15:30:46 UTC 
Sure, can do.
Comment 3 Ville Skyttä 2013-02-22 15:59:43 UTC 
http://pkgs.fedoraproject.org/cgit/udpcast.git/commit/?id=2aa71e8
(Took the liberty to make a few other cosmetic changes while at it.)
Note You need to log in before you can comment on or make changes to this bug.