Bug 917191

Summary: Review Request: awake - A command to 'wake on LAN' a remote host
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Björn Esser (besser82) <besser82>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: besser82, notting, package-review
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: besser82: fedora-review+
gwync: fedora-cvs+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: awake-1.0-1.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-15 03:03:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabian Affolter 2013-03-01 22:56:55 UTC 
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/awake.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/awake-1.0-1.fc18.src.rpm

Project URL: https://github.com/cyraxjoe/awake

Description:
A command to 'wake on LAN' a remote host.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5067854

rpmlint output:
[fab@localhost SRPMS]$ rpmlint awake-1.0-1.fc18.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@localhost noarch]$ rpmlint *awake*
awake.noarch: W: no-manual-page-for-binary awake
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fedora Account System Username: fab
Comment 1 Björn Esser (besser82) 2013-05-16 20:24:11 UTC 
Hi Fabian!

fedora-review and manual inspection shows me all is fine, but...

there are three rpms:

awake-1.0-1.fc20.noarch.rpm 
python-awake-1.0-1.fc20.noarch.rpm
python3-awake-1.0-1.fc20.noarch.rpm

awake-1.0-1 seems to be the main package having /usr/bin/awake executing the main-method (located in python{,3}-awake} on system's default python-interpreter. But there's no dependency on python{,3}-awake in the rpm...

I think you should resolve this using a virtual package (e.g. Provides: pyawake = %{version}) in python{,3}-awake and depending on this virt-pkg in awake-1.0-1 (Requires: pyawake = %{version}). This way yum will decide itself how to resolve this on the "cheapest" way, when a user invokes `yum install awake`.

Adding a man-page using helptoman, pod or asciidoc would be nice, too.

Since you are in packager-group since five years or so, I suppose it is ok when you fix this on SCM.

APPROVED!
Comment 2 Fabian Affolter 2013-06-02 12:19:47 UTC 
Thanks for the review, Björn.
Comment 3 Fabian Affolter 2013-06-02 12:21:22 UTC 
New Package SCM Request
=======================
Package Name: awake
Short Description: A command to 'wake on LAN' a remote host
Owners: fab
Branches: F18 F19
InitialCC:
Comment 4 Gwyn Ciesla 2013-06-03 10:23:45 UTC 
Git done (by process-git-requests).
Comment 5 Fedora Update System 2013-07-27 19:12:22 UTC 
awake-1.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/awake-1.0-1.fc19
Comment 6 Fedora Update System 2013-07-27 19:13:04 UTC 
awake-1.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/awake-1.0-1.fc18
Comment 7 Fedora Update System 2013-07-29 00:29:23 UTC 
awake-1.0-1.fc18 has been pushed to the Fedora 18 testing repository.
Comment 8 Fedora Update System 2013-08-15 03:03:38 UTC 
awake-1.0-1.fc18 has been pushed to the Fedora 18 stable repository.
Comment 9 Fedora Update System 2013-08-15 03:05:28 UTC 
awake-1.0-1.fc19 has been pushed to the Fedora 19 stable repository.