Spec URL: http://fab.fedorapeople.org/packages/SRPMS/awake.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/awake-1.0-1.fc18.src.rpm Project URL: https://github.com/cyraxjoe/awake Description: A command to 'wake on LAN' a remote host. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5067854 rpmlint output: [fab@localhost SRPMS]$ rpmlint awake-1.0-1.fc18.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [fab@localhost noarch]$ rpmlint *awake* awake.noarch: W: no-manual-page-for-binary awake 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab
Hi Fabian! fedora-review and manual inspection shows me all is fine, but... there are three rpms: awake-1.0-1.fc20.noarch.rpm python-awake-1.0-1.fc20.noarch.rpm python3-awake-1.0-1.fc20.noarch.rpm awake-1.0-1 seems to be the main package having /usr/bin/awake executing the main-method (located in python{,3}-awake} on system's default python-interpreter. But there's no dependency on python{,3}-awake in the rpm... I think you should resolve this using a virtual package (e.g. Provides: pyawake = %{version}) in python{,3}-awake and depending on this virt-pkg in awake-1.0-1 (Requires: pyawake = %{version}). This way yum will decide itself how to resolve this on the "cheapest" way, when a user invokes `yum install awake`. Adding a man-page using helptoman, pod or asciidoc would be nice, too. Since you are in packager-group since five years or so, I suppose it is ok when you fix this on SCM. APPROVED!
Thanks for the review, Björn.
New Package SCM Request ======================= Package Name: awake Short Description: A command to 'wake on LAN' a remote host Owners: fab Branches: F18 F19 InitialCC:
Git done (by process-git-requests).
awake-1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/awake-1.0-1.fc19
awake-1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/awake-1.0-1.fc18
awake-1.0-1.fc18 has been pushed to the Fedora 18 testing repository.
awake-1.0-1.fc18 has been pushed to the Fedora 18 stable repository.
awake-1.0-1.fc19 has been pushed to the Fedora 19 stable repository.