Bug 917706

Summary: guestfs_umount_local is not thread safe
Product: [Community] Virtualization Tools Reporter: Richard W.M. Jones <rjones>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: NEW --- QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: stenavin
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-10-17 00:10:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2013-03-04 15:30:59 UTC 
Description of problem:

The documentation for mount-local claims:

"Note you must not make concurrent libguestfs calls on the same handle from another thread, with the exception of guestfs_umount_local."

implying that guestfs_umount_local is thread-safe.  It certainly
is not safe to call guestfs_umount_local from another thread.
guestfs_umount_local could generate events, call the error handler,
or access other fields in the handle, with no locking at all.

Version-Release number of selected component (if applicable):

libguestfs 1.21.16

Additional info:

I have added a commit to fix the documentation.  However we
ought to make guestfs_umount_local thread-safe in future.
Comment 1 Red Hat Bugzilla 2025-10-17 00:10:03 UTC 
This product has been discontinued or is no longer tracked in Red Hat Bugzilla.
Comment 2 Alasdair Kergon 2025-10-17 12:52:13 UTC 
Reopening because Virtualization Tools has not been discontinued.