Bug 917706 - guestfs_umount_local is not thread safe
Summary: guestfs_umount_local is not thread safe
Keywords:
Status: NEW
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-04 15:30 UTC by Richard W.M. Jones
Modified: 2021-04-19 10:35 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description Richard W.M. Jones 2013-03-04 15:30:59 UTC
Description of problem:

The documentation for mount-local claims:

"Note you must not make concurrent libguestfs calls on the same handle from another thread, with the exception of guestfs_umount_local."

implying that guestfs_umount_local is thread-safe.  It certainly
is not safe to call guestfs_umount_local from another thread.
guestfs_umount_local could generate events, call the error handler,
or access other fields in the handle, with no locking at all.

Version-Release number of selected component (if applicable):

libguestfs 1.21.16

Additional info:

I have added a commit to fix the documentation.  However we
ought to make guestfs_umount_local thread-safe in future.


Note You need to log in before you can comment on or make changes to this bug.