Bug 918666

Summary:	Don't fail when a non-existing bond is requested via setupNetworks.
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Antoni Segura Puimedon <asegurap>
Component:	vdsm	Assignee:	Antoni Segura Puimedon <asegurap>
Status:	CLOSED ERRATA	QA Contact:	Meni Yakove <myakove>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.2.0	CC:	alkaplan, atal, bazulay, danken, hateya, iheim, jocarter, lpeer, lvernia, mkenneth, Rhev-m-bugs, sgrinber, yeylon, ykaul, zdover
Target Milestone:	---	Keywords:	CodeChange
Target Release:	3.2.0
Hardware:	x86_64
OS:	Windows
Whiteboard:	network
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously, when new bonds were added via the setupNetwork method (through either the GUI or the SDK), the validation of bonding options fails and the setupNetworks for the bond failed to apply. This was because the procedure that checked for existing bond device options was performed by determining whether sysfs exposed the bonds for the requested device. The bond required for validation is now created before the setupNetwork method is called. The bonding options check is now performed successfully, and requests for bonded networks comply with the rest of the network validation done by setupNetworks. In the case of incorrect bonding options, meaningful errors are provided to the user.	Story Points:	---
Clone Of:	649239
Clones:	951018 (view as bug list)		Environment:
Last Closed:	2013-06-10 20:42:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	649239
Bug Blocks:	647155, 649241, 951018

Description Antoni Segura Puimedon 2013-03-06 17:15:26 UTC

Description of problem:
When setupNetworks refers to a non-existing bond, setupNetworks will fail validating bond options.

How reproducible:
100%

Steps to Reproduce:
1.Send a setupNetworks command that refers to a non existing bond.
  
Actual results:
Error parsing bonding options 'mode=4'

Expected results:
operation should have finished without errors.

Additional info:

This is due to the fact that we check for existing bond device options by checking if sysfs exposes them. Since the requested bond does not exist when checking, we fail.

Cloning from a engine side bug. That side taken care of by the second link in tracker.

+++ This bug was initially created as a clone of Bug #649239 +++

Description of problem:
When adding new bond, the backend relies on the existing bonds.
This causes few problems: 
1. limit the number of bonds to 5 (which created by default by vdsm). 
2. if vdsm won't create bond[0-4] by default, the backend will pass Null bonds to the UI and the user won't be able to create bond at all.

The solution would be to add one more bond every time user call to create bond.
if vdsm return bond0 exists, backend will create bond1 and so on. 

note: This is not RFE because of an open vdsm bug 647155 which will cause backend to send Null to UI when creating new bond.

--- Additional comment from Avi Tal on 2010-12-26 08:52:34 EST ---

As for an RFE solution, backend should support adding more Bonds

--- Additional comment from Lior Vernia on 2013-02-28 10:45:47 EST ---

Still depends on a fix on VDSM side.

Comment 2 Dan Kenigsberg 2013-03-14 10:16:08 UTC

For rhev-3.2 this is only a CodeChange, as bond777 cannot be requested from Engine.

One may verify the change with

  vdsClient addNetwork bridge=bla bond=bond777 nics=eth4

Comment 5 Meni Yakove 2013-03-24 09:14:58 UTC

Verified on vdsm-4.10.2-12.0.el6ev.x86_64

Comment 6 Cheryn Tan 2013-04-03 07:01:27 UTC

This bug is currently attached to errata RHBA-2012:14332. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.

* Consequence: What happens when the bug presents.

* Fix: What was done to fix the bug.

* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes

Thanks in advance.

Comment 8 errata-xmlrpc 2013-06-10 20:42:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0886.html