Bug 919590
| Summary: | Review Request: python-tftpy - TFTP module for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeff Bastian <jbastian> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | blc, emcnabb, notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-tftpy-0.6.0-1.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-03-19 17:11:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 919592 | ||
|
Description
Jeff Bastian
2013-03-08 20:06:16 UTC
This is my first (of three, also see bug 919591 and bug 919592) packages so I need a sponsor. Hey Jeff. I'd love to see these in, so I am happy to try and work on reviewing and sponsoring you. Will try and get you a review of this package later today... OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: d8de06a543989b910e46d2793f96fb9c5cbd7f99ab014982945b58ae60289893 tftpy-0.6.0.tar.gz d8de06a543989b910e46d2793f96fb9c5cbd7f99ab014982945b58ae60289893 tftpy-0.6.0.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: python-tftpy.noarch: W: spelling-error %description -l en_US tsize -> size, t size python-tftpy.noarch: W: no-manual-page-for-binary tftpy_client.py python-tftpy.noarch: W: no-manual-page-for-binary tftpy_server.py python-tftpy.src: W: spelling-error %description -l en_US tsize -> size, t size 2 packages and 0 specfiles checked; 0 errors, 4 warnings. All those can be ignored. I don't see any bockers here, so this package is APPROVED. Let me go ahead and review your other two and see about sponsoring you after those are done. Since the other two are waiting on that ipmitool bug to get fixed, I'll go ahead and sponsor you and you can get this one imported and done. New Package SCM Request ======================= Package Name: python-tftpy Short Description: TFTPy is a pure Python implementation of the Trivial FTP protocol Owners: jbastian Branches: f18 f19 InitialCC: I see python-tftpy is already in git, but it is retired. Maybe it just needs to be un-retired for Fedora 18? http://pkgs.fedoraproject.org/cgit/python-tftpy.git/ Un-retired for devel, file a Package Change request for f19, f18, etc. Package Change Request ====================== Package Name: python-tftpy New Branches: f18 f19 Owners: jbastian Git done (by process-git-requests). I'm waiting for the package to be unblocked before I can build. https://fedorahosted.org/rel-eng/ticket/5531 python-tftpy-0.6.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-tftpy-0.6.0-1.fc18 python-tftpy-0.6.0-1.fc18 has been pushed to the Fedora 18 stable repository. |