Bug 920376
| Summary: | other Fatal error: Exception down the road , when url got %20 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sergio Basto <sergio> | ||||
| Component: | fedora-review | Assignee: | Stanislav Ochotnicky <sochotni> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 18 | CC: | leamas.alec, pingou, sochotni | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | fedora-review-0.4.1-1.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-03-13 06:04:39 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Sergio Basto
2013-03-11 23:12:49 UTC
(In reply to comment #0) >So I workaround the problem but this bug report could still valid I don't know. Actually, this is not a problem in fedora-review but in parsing the spec file. Try to build the package in mock and you will see. In case it does work, having the logs would help, see: >ERROR: Exception down the road...(logs in /home/sergio/.cache/fedora-review.log) Created attachment 708773 [details]
traceback
Hi,
vi /usr/lib/python2.7/site-packages/FedoraReview/spec_file.py
on line 123
for (url, num, flags) in self.spec.sources:
If I got url with %20 will traceback in line 127
result[tag] = self.spec.sourceHeader.format(url)
I know this kind of error, url can't have % because it will be consider a string format.
Also works if we put
url = url.replace('%' ,'%%')
before
result[tag] = self.spec.sourceHeader.format(url)
Sergio: Can you please attach the complete log at ~/.cache/fedora-review so we can reproduce this? OK, steps to reproduce: - yumdownloader --source PyPE - ./try-fedora-review -rn PyPE-2.9.1-7.fc18.src.rpm gives this crash. So: no log needed. OK, there's a fix in devel, see http://git.fedorahosted.org/cgit/FedoraReview.git/commit/?id=e854054. (In reply to comment #5) > OK, there's a fix in devel, see > http://git.fedorahosted.org/cgit/FedoraReview.git/commit/?id=e854054. fine, closing as fixed in next release Thanks :) fedora-review-0.4.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc18 fedora-review-0.4.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.el6 fedora-review-0.4.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc19 fedora-review-0.4.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc17 fedora-review-0.4.1-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. fedora-review-0.4.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |