Description of problem: I'm trying review package PyPE I got ERROR: Exception down the road...(logs in /home/sergio/.cache/fedora-review.log) early Source0: http://downloads.sourceforge.net/project/pype/pype/PyPE%202.9.4/PyPE-2.9.4-src.zip Version-Release number of selected component (if applicable): 0.4.0-4.fc18 Actual results: Exception down the road Expected results: no Exception down the road Additional info: while I file this bug I found that : http://downloads.sourceforge.net/project/pype/pype/PyPE 2.9.4/PyPE-2.9.4-src.zip works instead %20 I put a space like we see it on browser. So I workaround the problem but this bug report could still valid I don't know.
(In reply to comment #0) >So I workaround the problem but this bug report could still valid I don't know. Actually, this is not a problem in fedora-review but in parsing the spec file. Try to build the package in mock and you will see. In case it does work, having the logs would help, see: >ERROR: Exception down the road...(logs in /home/sergio/.cache/fedora-review.log)
Created attachment 708773 [details] traceback Hi, vi /usr/lib/python2.7/site-packages/FedoraReview/spec_file.py on line 123 for (url, num, flags) in self.spec.sources: If I got url with %20 will traceback in line 127 result[tag] = self.spec.sourceHeader.format(url) I know this kind of error, url can't have % because it will be consider a string format. Also works if we put url = url.replace('%' ,'%%') before result[tag] = self.spec.sourceHeader.format(url)
Sergio: Can you please attach the complete log at ~/.cache/fedora-review so we can reproduce this?
OK, steps to reproduce: - yumdownloader --source PyPE - ./try-fedora-review -rn PyPE-2.9.1-7.fc18.src.rpm gives this crash. So: no log needed.
OK, there's a fix in devel, see http://git.fedorahosted.org/cgit/FedoraReview.git/commit/?id=e854054.
(In reply to comment #5) > OK, there's a fix in devel, see > http://git.fedorahosted.org/cgit/FedoraReview.git/commit/?id=e854054. fine, closing as fixed in next release Thanks :)
fedora-review-0.4.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc18
fedora-review-0.4.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.el6
fedora-review-0.4.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc19
fedora-review-0.4.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fedora-review-0.4.1-1.fc17
fedora-review-0.4.1-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
fedora-review-0.4.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.