Bug 921896
| Summary: | Single quote in f19 release name breaks grub2, probably other stuff | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | fedora-release | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | cpatrick08, dan.mashal, dennis, jreznik, keramidasceid, michele, notting, petersen, robatino, satellitgo |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | AcceptedBlocker | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-03-20 18:31:52 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 834084 | ||
|
Description
Adam Williamson
2013-03-15 08:21:22 UTC
I think grubby actually parses /etc/os-release , now I look at the code. But whatever we should do, we should probably do everywhere. > The umlauted o could conceivably cause problems somewhere too
The ö only renders correctly on the kernel console if /etc/fedora-release
is encoding in iso8859-1 instead of utf-8. But changing the encoding would
likely mess up grub, etc instead, so I agree with the sentiment to
transliterate to ASCII.
Unless quoting ' works, maybe "Schroedingers Cat" is good enough?
(I will test more \' once a new f19 kernel lands.)
I think there need to be character restrictions for future release name suggestions...
(In reply to comment #2) > > The umlauted o could conceivably cause problems somewhere too > > The ö only renders correctly on the kernel console if /etc/fedora-release > is encoding in iso8859-1 instead of utf-8. But changing the encoding would > likely mess up grub, etc instead, so I agree with the sentiment to > transliterate to ASCII. > > Unless quoting ' works, maybe "Schroedingers Cat" is good enough? > (I will test more \' once a new f19 kernel lands.) Works for me. > > I think there need to be character restrictions for future release name > suggestions... On the other hand it would be great to make it working - instead of setting limitations for future names. Can we please paint the bikeshed that color *right now*? We have enough real bugs to deal with and having this one in the way is just complicating matters. Well, I'm definitely in favour of release name tweak but if we do it now, then I'd like to stick with it for final too (not only for Alpha). Proposed "Schroedingers Cat" should work, we usually don't show it anywhere (correct me if I'm right). Dennis? Why would the ö only work if it's 8859-1? We switch the console to unicode very early in boot. Personally, I'd just replace the ' with whatever the unicode quote equivalent is, and fix any weird quoting grub issues that way. jaro: it's shown in the bootloader menu for post-release update kernels - that's the whole bug here - and at the tty login prompt, at least. Probably other places. we have fixed up the ' today (In reply to comment #7) > jaro: it's shown in the bootloader menu for post-release update kernels - > that's the whole bug here - and at the tty login prompt, at least. Probably > other places. Ah, sorry - I don't know what I was thinking about in time I wrote that comment :( Discussed at 2013-03-20 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2013-03-20/f19alpha-blocker-review-2.2013-03-20-16.00.log.txt . Accepted as a blocker per criterion https://fedoraproject.org/wiki/Fedora_19_Alpha_Release_Criteria#Expected_installed_system_boot_behavior: "After firstboot is completed and on subsequent boots, a graphical install must boot to a log in screen where it is possible to log in to a working desktop as the user created during firstboot." - as soon as you apply a kernel update, system stops booting. The updated fedora-release is out already, I just need to test and verify it fixes the problem. it fixes the problem for me upgraded 18 to 19 via yum and I got a working 19 system Thanks, Christopher. (In reply to comment #6) > Why would the ö only work if it's 8859-1? We switch the console to unicode > very early in boot. Ok it seems to work after rebooting into fedora-release-19-0.5 - the console font seems to be a bit stateful... > Personally, I'd just replace the ' with whatever the unicode quote > equivalent is, and fix any weird quoting grub issues that way. That renders as a box for me on the console but I can live with that for now. Things look ok in grub now anyway. |