Bug 921932

Summary: Update lessjs and expose for other Node.js modules
Product: [Fedora] Fedora Reporter: Jamie Nguyen <jamielinux>
Component: lessjsAssignee: Stephen Gallagher <sgallagh>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mrunge, sgallagh, tchollingsworth
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-15 10:15:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Update to upstream release 1.3.3
none
Expose lessjs for other Node.js modules none

Description Jamie Nguyen 2013-03-15 09:57:53 UTC
Currently the lessjs package does not place anything in /usr/lib/node_modules so that other Node.js modules can make use of it.

I'm proposing two patches to the lessjs package which I will add in the comments below.

I would also like to offer to co-maintain lessjs. If you approve of the changes to the spec then I would be more than happy to lend a hand and apply them myself.

nodejs-jade (one of my packages) uses npm(less) in the %check section. It works and all tests pass when using the new lessjs package I have proposed.

Comment 1 Jamie Nguyen 2013-03-15 09:59:50 UTC
Created attachment 710531 [details]
Update to upstream release 1.3.3

This updates to 1.3.3 and removes three of the patches that are no longer required:
 - cssmin.js has been unbundled upstream
 - the dist/ folder is no longer included
 - the version number is now correct

I've also switched the source to use the npm tarball rather than the GitHub tarball.

Comment 2 Jamie Nguyen 2013-03-15 10:01:17 UTC
Created attachment 710532 [details]
Expose lessjs for other Node.js modules

This just adds the /usr/lib/node_modules/less folder with a package.json file and symlinks to the relevant places. This will allow require('less') to work in various Node.js modules.

Comment 3 Matthias Runge 2013-03-15 10:15:25 UTC

*** This bug has been marked as a duplicate of bug 921365 ***

Comment 4 T.C. Hollingsworth 2013-03-15 23:39:26 UTC
Thanks, but we really should just move everything to %{nodejs_sitelib} and only have the browser verision in %{_datadir}.  I have everything mostly done locally already.

If you want to help out we need ycssmin in bug 921847 reviewed to finish everything up,