Bug 922716

Sent patches to the ML:
https://www.redhat.com/archives/virt-tools-list/2013-July/msg00124.html

I can reproduce this with:
virt-viewer-0.5.6-1.el7.x86_64

Steps:
1. prepare a guest, rhel6.4
2. # virt-viewer rhel6.4  --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
   Check the menu "Send key"
3. # remote-viewer spice://127.0.0.1:5901 --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
   Check the menu "Send key"

Result:
step2, step3, hotkeys work well, but,there is no the hotkeys which is set by cmdline in the menu.


Verify:
virt-viewer-0.5.7-1.el7.x86_64
Steps:
Same as above.

Result:

The hotkeys work well, and in the menu "Send key", can see the hotkeys at the bottom.

But, if I click the hotkeys in the menu, it can't work, and there is a "ctrl+0" at the bottom of the menu, but I didn't set the hotkey.

So, set ASSIGNED.

(In reply to CongDong from comment #4)
> Result:
> 
> The hotkeys work well, and in the menu "Send key", can see the hotkeys at
> the bottom.
> 
> But, if I click the hotkeys in the menu, it can't work, and there is a
> "ctrl+0" at the bottom of the menu, but I didn't set the hotkey.
> 
> So, set ASSIGNED.

My guess is you are having the "modifier order" bug fixed in upstream b80e7f0f2 
https://bugzilla.redhat.com/show_bug.cgi?id=846006.

Is there any chance you could try the git version of virt-viewer? thanks

(In reply to Marc-Andre Lureau from comment #5)
> My guess is you are having the "modifier order" bug fixed in upstream
> b80e7f0f2 
> https://bugzilla.redhat.com/show_bug.cgi?id=846006.
> 
> Is there any chance you could try the git version of virt-viewer? thanks

Hi,

I got the b80e7f0f2 code, but I cannot compile correctly, after "make install" it, there is no command "virt-viewer", "remote-viewer" can be used, but cannot connect the spice guest, so can you help me to compile it ?

(In reply to CongDong from comment #6)
> (In reply to Marc-Andre Lureau from comment #5)
> > My guess is you are having the "modifier order" bug fixed in upstream
> > b80e7f0f2 
> > https://bugzilla.redhat.com/show_bug.cgi?id=846006.
> > 
> > Is there any chance you could try the git version of virt-viewer? thanks
> 
> Hi,
> 
> I got the b80e7f0f2 code, but I cannot compile correctly, after "make
> install" it, there is no command "virt-viewer", "remote-viewer" can be used,
> but cannot connect the spice guest, so can you help me to compile it ?

have you done a yum-builddep virt-viewer before? spice-gtk-devel must be installed to get spice support. thanks

(In reply to Marc-Andre Lureau from comment #7)
> have you done a yum-builddep virt-viewer before? spice-gtk-devel must be
> installed to get spice support. thanks

I installed spice-gtk-devel, still no "virt-viewer", but command "remote-viewer" can connect spice guest.

# remote-viewer spice://127.0.0.1:5900 --hotkeys=toggle-fullscreen=shift+f11

Check the menu "Send key",

Two more items there:
...
Shift+11
Ctrl+0


If I click them, they don't work.

(In reply to CongDong from comment #8)
> Shift+11
> Ctrl+0
> 
> 
> If I click them, they don't work.

coould you get the log of xev when clicking those items?

thanks

Created attachment 813602 [details]
xev log when clicking shift+f11 and ctrl+0

(In reply to CongDong from comment #10)
> Created attachment 813602 [details]
> xev log when clicking shift+f11 and ctrl+0

there is no Press/Release even in this log. Make sure xev has the focus,

Launching remote-viewer spice://192.168.1.42:5901 --hotkeys=toggle-fullscreen=shift+f11:

- with virt-viewer-0.5.7-2.el7.x86_64

KeyPress event, serial 33, synthetic NO, window 0x4600001,
    state 0x0, keycode 95 (keysym 0xffc8, F11), same_screen YES,
KeyPress event, serial 33, synthetic NO, window 0x4600001,
    state 0x0, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
KeyRelease event, serial 33, synthetic NO, window 0x4600001,
    state 0x1, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
KeyRelease event, serial 33, synthetic NO, window 0x4600001,
    state 0x0, keycode 95 (keysym 0xffc8, F11), same_screen YES,

KeyPress event, serial 33, synthetic NO, window 0x2a00001,
    state 0x0, keycode 19 (keysym 0x30, 0), same_screen YES,
KeyPress event, serial 33, synthetic NO, window 0x2a00001,
    state 0x0, keycode 37 (keysym 0xffe3, Control_L), same_screen YES,
KeyRelease event, serial 33, synthetic NO, window 0x2a00001,
    state 0x4, keycode 37 (keysym 0xffe3, Control_L), same_screen YES,
KeyRelease event, serial 33, synthetic NO, window 0x2a00001,
    state 0x0, keycode 19 (keysym 0x30, 0), same_screen YES,

- with upstream fix b80e7f0f2:

KeyPress event, serial 30, synthetic NO, window 0x4600001,
    state 0x0, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
KeyPress event, serial 30, synthetic NO, window 0x4600001,
    state 0x1, keycode 95 (keysym 0xffc8, F11), same_screen YES,
KeyRelease event, serial 30, synthetic NO, window 0x4600001,
    state 0x1, keycode 95 (keysym 0xffc8, F11), same_screen YES,
KeyRelease event, serial 30, synthetic NO, window 0x4600001,
    state 0x1, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,


KeyPress event, serial 30, synthetic NO, window 0x2a00001,
    state 0x0, keycode 37 (keysym 0xffe3, Control_L), same_screen YES,
KeyPress event, serial 30, synthetic NO, window 0x2a00001,
    state 0x4, keycode 19 (keysym 0x30, 0), same_screen YES,
KeyRelease event, serial 30, synthetic NO, window 0x2a00001,
    state 0x4, keycode 19 (keysym 0x30, 0), same_screen YES,
KeyRelease event, serial 30, synthetic NO, window 0x2a00001,
    state 0x4, keycode 37 (keysym 0xffe3, Control_L), same_screen YES,

moving back to POST

Moving back to POST, patch for upstream commit b80e7f0f2 must be added to the curretn build.

Tested with:
virt-viewer-0.5.7-6.el7.x86_64

Steps:
1. prepare a guest named test.
2. # virt-viewer test --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
3.Check the menu "Send key"
4. # remote-viewer spice://127.0.0.1:5901 --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
5.Check the menu "Send key"


Step 2 and step 4,The hotkeys work well by pressing keys.But if I click the hotkeys in the menu, it can't work.

Step 3 and step 5,in the menu "Send key", can see the hotkeys at the bottom.But there is a "ctrl+0" at the bottom of the menu which is not be setted by the hotkey.

Refer to the above comments,move the bug to ASSIGNED.

(In reply to tingting zheng from comment #13)
> Tested with:
> virt-viewer-0.5.7-6.el7.x86_64
> 
> Steps:
> 1. prepare a guest named test.
> 2. # virt-viewer test
> --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
> 3.Check the menu "Send key"
> 4. # remote-viewer spice://127.0.0.1:5901
> --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
> 5.Check the menu "Send key"
> 
> 
> Step 2 and step 4,The hotkeys work well by pressing keys.But if I click the
> hotkeys in the menu, it can't work.

Can you expand on "work"/"can't work" ? When you say "work", I assume you mean "shift+f11" toggles fullscreen ? When you select shift+f11 in the menu, it's not expected to toggle fullscreen, but rather to send shift+f11 to the guest. Is this what you tested, and which did not work? How did you test if the guest received shift+f11?

(In reply to Christophe Fergeau from comment #14)
> (In reply to tingting zheng from comment #13)
> > Tested with:
> > virt-viewer-0.5.7-6.el7.x86_64
> > 
> > Steps:
> > 1. prepare a guest named test.
> > 2. # virt-viewer test
> > --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
> > 3.Check the menu "Send key"
> > 4. # remote-viewer spice://127.0.0.1:5901
> > --hotkeys=toggle-fullscreen=shift+f11,release-cursor=shift+f12
> > 5.Check the menu "Send key"
> > 
> > 
> > Step 2 and step 4,The hotkeys work well by pressing keys.But if I click the
> > hotkeys in the menu, it can't work.
> 
> Can you expand on "work"/"can't work" ? When you say "work", I assume you
> mean "shift+f11" toggles fullscreen ? When you select shift+f11 in the menu,
> it's not expected to toggle fullscreen, but rather to send shift+f11 to the
> guest. Is this what you tested, and which did not work? How did you test if
> the guest received shift+f11?


When I press "shift+f11" by keyboard,it toggles fullscreen,while I click shift+f11 in the menu,it doesn't toggle fullscreen.

(In reply to tingting zheng from comment #15)
> When I press "shift+f11" by keyboard,it toggles fullscreen,while I click
> shift+f11 in the menu,it doesn't toggle fullscreen.

Yes, when clicking shift+f11 in the menu, the key combination should go to the guest, it's not meant to toggle fullscreen. In a linux guest, you can use xev to check if the key combination reaches the guest. Or you can run a remote-viewer instance in the guest, and check remote-viewer gets fullscreen in the guest when you choose shift+f11 in the menu.

(In reply to Christophe Fergeau from comment #16)
> (In reply to tingting zheng from comment #15)
> > When I press "shift+f11" by keyboard,it toggles fullscreen,while I click
> > shift+f11 in the menu,it doesn't toggle fullscreen.
> 
> Yes, when clicking shift+f11 in the menu, the key combination should go to
> the guest, it's not meant to toggle fullscreen. In a linux guest, you can
> use xev to check if the key combination reaches the guest. Or you can run a
> remote-viewer instance in the guest, and check remote-viewer gets fullscreen
> in the guest when you choose shift+f11 in the menu.

Thanks for your clear explanation.
Tested again:
When I click shift+f11 in the menu,it did get the key combination in guest,the xev command shows as below:
KeyPress event, serial 30, synthetic NO, window 0x3c00001,
    root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
    state 0x10, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
    XLookupString gives 0 bytes: 
    XmbLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyPress event, serial 30, synthetic NO, window 0x3c00001,
    root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
    state 0x11, keycode 95 (keysym 0xffc8, F11), same_screen YES,
    XLookupString gives 0 bytes: 
    XmbLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyRelease event, serial 30, synthetic NO, window 0x3c00001,
    root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
    state 0x11, keycode 95 (keysym 0xffc8, F11), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

KeyRelease event, serial 30, synthetic NO, window 0x3c00001,
    root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
    state 0x11, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
    XLookupString gives 0 bytes: 
    XFilterEvent returns: False

So it is expected result,right?Then there exist another issue:there is a "ctrl+0" at the bottom of the menu which is not be setted by the hotkey.

(In reply to tingting zheng from comment #17)
> Thanks for your clear explanation.
> Tested again:

Thanks for the additional testing!

> When I click shift+f11 in the menu,it did get the key combination in
> guest,the xev command shows as below:
> KeyPress event, serial 30, synthetic NO, window 0x3c00001,
>     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
>     state 0x10, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
>     XLookupString gives 0 bytes: 
>     XmbLookupString gives 0 bytes: 
>     XFilterEvent returns: False
> 
> KeyPress event, serial 30, synthetic NO, window 0x3c00001,
>     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
>     state 0x11, keycode 95 (keysym 0xffc8, F11), same_screen YES,
>     XLookupString gives 0 bytes: 
>     XmbLookupString gives 0 bytes: 
>     XFilterEvent returns: False
> 
> KeyRelease event, serial 30, synthetic NO, window 0x3c00001,
>     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
>     state 0x11, keycode 95 (keysym 0xffc8, F11), same_screen YES,
>     XLookupString gives 0 bytes: 
>     XFilterEvent returns: False
> 
> KeyRelease event, serial 30, synthetic NO, window 0x3c00001,
>     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
>     state 0x11, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
>     XLookupString gives 0 bytes: 
>     XFilterEvent returns: False
> 
> So it is expected result,right?

Yes this looks correct.

> Then there exist another issue:there is a
> "ctrl+0" at the bottom of the menu which is not be setted by the hotkey.

And this ctrl+0 is not listed in the menu if you run virt-viewer without the --hotkeys parameter? This is a different bug anyway, so I suggest to move this bug to VERIFIED if your testing shows the initial issue is fixed, and opening a new bug for this ctrl+0 issue.

(In reply to Christophe Fergeau from comment #18)
> (In reply to tingting zheng from comment #17)
> > Thanks for your clear explanation.
> > Tested again:
> 
> Thanks for the additional testing!
> 
> > When I click shift+f11 in the menu,it did get the key combination in
> > guest,the xev command shows as below:
> > KeyPress event, serial 30, synthetic NO, window 0x3c00001,
> >     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
> >     state 0x10, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
> >     XLookupString gives 0 bytes: 
> >     XmbLookupString gives 0 bytes: 
> >     XFilterEvent returns: False
> > 
> > KeyPress event, serial 30, synthetic NO, window 0x3c00001,
> >     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
> >     state 0x11, keycode 95 (keysym 0xffc8, F11), same_screen YES,
> >     XLookupString gives 0 bytes: 
> >     XmbLookupString gives 0 bytes: 
> >     XFilterEvent returns: False
> > 
> > KeyRelease event, serial 30, synthetic NO, window 0x3c00001,
> >     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
> >     state 0x11, keycode 95 (keysym 0xffc8, F11), same_screen YES,
> >     XLookupString gives 0 bytes: 
> >     XFilterEvent returns: False
> > 
> > KeyRelease event, serial 30, synthetic NO, window 0x3c00001,
> >     root 0x107, subw 0x0, time 515620, (-536,-130), root:(308,5),
> >     state 0x11, keycode 50 (keysym 0xffe1, Shift_L), same_screen YES,
> >     XLookupString gives 0 bytes: 
> >     XFilterEvent returns: False
> > 
> > So it is expected result,right?
> 
> Yes this looks correct.
> 
> > Then there exist another issue:there is a
> > "ctrl+0" at the bottom of the menu which is not be setted by the hotkey.
> 
> And this ctrl+0 is not listed in the menu if you run virt-viewer without the
> --hotkeys parameter? This is a different bug anyway, so I suggest to move
> this bug to VERIFIED if your testing shows the initial issue is fixed, and
> opening a new bug for this ctrl+0 issue.

Refer to the comments,I file new bug 1063195 to track the new ctrl+0 issue.
Refer comment 13,14,17,18,move the bug to VERIFIED.

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.