Bug 92335

Summary: htmlview can't open files with names which include spaces
Product: [Fedora] Fedora Reporter: Moritz Barsnick <moritz>
Component: htmlviewAssignee: Warren Togami <wtogami>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-04-25 04:53:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 100644    
Attachments:
Description Flags
patch to allow htmlview to handle file names with whitespace none

Description Moritz Barsnick 2003-06-05 08:46:21 UTC
Description of problem:
htmlview fails to open files with names which have spaces or special chars. 
File names with spaces are passed as separated arguments.

Version-Release number of selected component (if applicable):
2.0.0-9

How reproducible:
always

Steps to Reproduce:
1. htmlview "/path/to/file name with spaces.html" (or any proper quoting)
2.
3.
    
Actual results:
File is not displayed, because the called viewer sees "htmlview /path/to/file"

Expected results:
File is displayed.

Additional info:
This is very obviously the classic $* vs. "$@". "$@" ist the correct way to 
pass "all arguments". There are three "exec" calls where this needs to be 
fixed. I can provide a patch, but I guess you won't need it.  ;-)  Just be sure 
to use "$@" _with_ the double quotes!

Comment 1 Moritz Barsnick 2004-11-01 14:37:21 UTC
Created attachment 106013 [details]
patch to allow htmlview to handle file names with whitespace

Still the same problem 17 months later in version 3.0.0-8. Here's a patch.

If you really don't want to allow multiple file names to be passed, try "$1".
OTOH "$*" will fail when getting multiple files and one of them contains spaces
(but I haven't checked whether the script passes this kind of arg to this
code).

Comment 2 Warren Togami 2004-11-06 22:17:37 UTC
warren@redhat.com is NOT my address.

Comment 3 Warren Togami 2005-04-25 04:53:03 UTC
Thanks.