Bug 924135

Created attachment 713678 [details]
anaconda.log

Created attachment 713679 [details]
ifcfg.log

Created attachment 713680 [details]
packaging.log

Created attachment 713681 [details]
program.log

Created attachment 713682 [details]
storage.log

Created attachment 713683 [details]
storage.state

Created attachment 713684 [details]
syslog

This is working exactly as we want it to work now.  Previously, users found the presence of both a Done and a Finish Partitioning button to be confusing and I don't blame them.  They sound like exactly the same thing, and this is the one place in anaconda where a spoke has a button in the bottom right in addition to the top left.  Weird.

Now, there's only the one button to deal with and we can detect what you've done and whether we need to do anything for you or not.  I'm not going to be making further changes here.

Still I would like to find out if it's confusing for other people as well.. Because of that I wanted to start a discussion.. 

Also, I mentioned that any hint message could also solve this problem.. But because the dialog is already pretty crowded, I don't see any place where to put such message so that it's not disturbing.

Chris, look at following use case:

1. create custom partitioning and return to the main hub
2. go to the Installation destination spoke

Now change your mind and decide not to make any additional changes. There are two ways how to go back to the main hub:
1. Click on "Done", "Custom partitioning", "Done" and "Accept Changes"
2. Click on "Back"

Unfortunately, the second way is not implemented.

You cannot deselect all disks and click "Done", since anaconda will complain that "No disk selected".

You already outlined a way to return to the main hub, though.  Done -> Custom -> Done -> Accept.

What you are asking for here is that we optimize for the less common case.  Throughout the development of F18 and after its release, we have gotten feedback that says having the Done and Continue buttons is confusing.  It is.  The changes we have made streamline things for the vast majority of users.

Given that there is a way back to the hub regardless, and that I don't believe very many people are actually going to have to go this way at all, I'm still not going to make any changes here.  I think you guys are just used to having the two buttons given that's how we released it.  We'd always intended to go back and get rid of the one button, we just didn't have a plan for how.

I just thought of this, though.  What I can do is change the spoke so if you make no changes in the disk selection, go straight back to the hub without doing anything.  That won't solve the complaint that the done button does multiple things, but it will achieve the ultimate goal of getting back to the hub faster.

Besides, that behavior (if you don't change anything, anaconda shouldn't do anything) is what we do on the other spokes.

>> You already outlined a way to return to the main hub, though.  Done -> Custom -> Done -> Accept.

This is not how well designed application should work.

>> What you are asking for here is that we optimize for the less common case.

Yes, it's less common case. But why should users suffer from this when they for example click on "Installation destination" by mistake?

And as I already told you, it's not clear how to return to main hub when you click on "Installation destination". The disk is selected by default if there's only one, and actually there is really nothing which tells you that you have to deselect the drive and hit "Done". I don't say this should be some sort of message, actually this should be clearly visible from the dialog design..