Bug 926968

Summary: Review Request: php-MiniTemplator - Compact template engine for HTML files
Product: [Fedora] Fedora Reporter: Sébastien Willmann <sebastien.willmann>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mrunge, package-review
Target Milestone: ---Flags: fedora: fedora-review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-26 12:19:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 836810    
Attachments:
Description Flags
review.txt
none
phpci.log none

Description Sébastien Willmann 2013-03-24 15:07:25 UTC 
Spec URL: http://wilqu.fedorapeople.org/reviews/php-MiniTemplator/php-MiniTemplator.spec
SRPM URL: http://wilqu.fedorapeople.org/reviews/php-MiniTemplator/php-MiniTemplator-2004.11.20-1.fc18.src.rpm
Description: MiniTemplator is a compact template engine for HTML files.

It is available in Java, PHP and Visual Basic. This package contains the PHP
version.
Fedora Account System Username: wilqu
Comment 1 Remi Collet 2013-04-15 12:27:20 UTC 
Created attachment 735882 [details]
review.txt

Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 926968
Comment 2 Remi Collet 2013-04-15 12:30:40 UTC 
Created attachment 735884 [details]
phpci.log

phpci version 2.15.0.
Comment 3 Remi Collet 2013-04-15 12:32:20 UTC 
First important question : do you really want to maintain this package which seems obviously dead upstream: ~9 year old version...

[!]: All build dependencies are listed in BuildRequires, except for any that are
  listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: unzip
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

	Also use "%setup -q -c" instead of direct call to unzip

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

	Please add link to the request

[!]: Packages should try to preserve timestamps of original installed files.

	use "install -p" or "cp -p" instead of cp

[!]: SourceX is a working URL.
	Non-versioned URL, should switch to sourceforge which 
	provides versioned URL.

[!]: Rpmlint is run on all installed packages.

	Easy to fix: wrong-file-end-of-line-encoding
Comment 4 Remi Collet 2013-10-14 08:26:37 UTC 
ping
Comment 5 Sébastien Willmann 2014-01-26 12:19:10 UTC 
> First important question : do you really want to maintain this package which seems obviously dead upstream

Not anymore… I gave up Tiny Tiny RSS so I’m closing this as well.