Spec URL: http://wilqu.fedorapeople.org/reviews/php-MiniTemplator/php-MiniTemplator.spec SRPM URL: http://wilqu.fedorapeople.org/reviews/php-MiniTemplator/php-MiniTemplator-2004.11.20-1.fc18.src.rpm Description: MiniTemplator is a compact template engine for HTML files. It is available in Java, PHP and Visual Basic. This package contains the PHP version. Fedora Account System Username: wilqu
Created attachment 735882 [details] review.txt Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 926968
Created attachment 735884 [details] phpci.log phpci version 2.15.0.
First important question : do you really want to maintain this package which seems obviously dead upstream: ~9 year old version... [!]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: unzip See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Also use "%setup -q -c" instead of direct call to unzip [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Please add link to the request [!]: Packages should try to preserve timestamps of original installed files. use "install -p" or "cp -p" instead of cp [!]: SourceX is a working URL. Non-versioned URL, should switch to sourceforge which provides versioned URL. [!]: Rpmlint is run on all installed packages. Easy to fix: wrong-file-end-of-line-encoding
ping
> First important question : do you really want to maintain this package which seems obviously dead upstream Not anymore… I gave up Tiny Tiny RSS so I’m closing this as well.