Bug 927461 (ros)

Summary:	Review Request: ros - The Robot Operating System
Product:	[Fedora] Fedora	Reporter:	Rich Mattes <richmattes>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	i
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-08 00:45:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	927458, 1062843
Bug Blocks:	201449, 972345, 972348

Description Rich Mattes 2013-03-26 01:10:27 UTC

Spec URL: http://rmattes.fedorapeople.org/rospackages/ros/ros.spec
SRPM URL: http://rmattes.fedorapeople.org/rospackages/ros/ros-1.8.10-2.fc18.src.rpm
Description:
ROS is a meta-operating system for your robot.  It provides language-
independent and network-transparent communication for a distributed
robot control system.

Fedora Account System Username: rmattes

rpmlint:
$ rpmlint ros.spec ../../RPMS/x86_64/ros-*-1.8.10-2*
ros.spec: W: invalid-url Source0: ros-1.8.10.tar.bz2
ros-devel.x86_64: W: no-documentation

The source is exported from an SVN tag with the instructions in the specfile

Comment 1 Rich Mattes 2013-06-08 16:58:58 UTC

Update:
Spec URL: http://rmattes.fedorapeople.org/rospackages/ros/ros.spec
SRPM URL: http://rmattes.fedorapeople.org/rospackages/ros/ros-1.8.10-3.20130608git0c13adb.fc19.src.rpm

I split up all of the ros stacks into subpackages and made most of them noarch where possible.  I also fixed the package to comply with the github sourceurl and snapshot packaging guidelines.

rpmlint trips up on more typos due to there being more description:
ros.x86_64: E: explicit-lib-dependency roslib
ros.x86_64: E: no-binary
roslib.x86_64: E: invalid-soname /usr/lib64/libroslib.so libroslib.so
roslib.x86_64: W: no-documentation
roslib-devel.x86_64: W: no-documentation
rosbash.noarch: W: no-documentation
rosbash.noarch: W: no-manual-page-for-binary rosrun
rosboost_cfg.noarch: W: spelling-error %description -l en_US rosboost -> booster, rooster, roost
rosboost_cfg.noarch: W: spelling-error %description -l en_US cfg -> cf, cg, cog
rosboost_cfg.noarch: W: spelling-error %description -l en_US cflags -> flags, c flags, cf lags
rosboost_cfg.noarch: W: spelling-error %description -l en_US lflags -> flags, l flags, lags
rosboost_cfg.noarch: W: no-documentation
rosboost_cfg.noarch: W: no-manual-page-for-binary rosboost-cfg
rosbuild.noarch: W: spelling-error %description -l en_US CMake -> C Make, Cake, Make
rosbuild.noarch: W: no-documentation
rosclean.noarch: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systemically
rosclean.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
rosclean.noarch: W: no-documentation
rosclean.noarch: W: no-manual-page-for-binary rosclean
roscreate.noarch: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systemically
roscreate.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
roscreate.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
roscreate.noarch: W: no-documentation
roscreate.noarch: W: no-manual-page-for-binary roros.x86_64: E: explicit-lib-dependency roslib
ros.x86_64: E: no-binary
roslib.x86_64: E: invalid-soname /usr/lib64/libroslib.so libroslib.so
roslib.x86_64: W: no-documentation
roslib-devel.x86_64: W: no-documentation
rosbash.noarch: W: no-documentation
rosbash.noarch: W: no-manual-page-for-binary rosrun
rosboost_cfg.noarch: W: spelling-error %description -l en_US rosboost -> booster, rooster, roost
rosboost_cfg.noarch: W: spelling-error %description -l en_US cfg -> cf, cg, cog
rosboost_cfg.noarch: W: spelling-error %description -l en_US cflags -> flags, c flags, cf lags
rosboost_cfg.noarch: W: spelling-error %description -l en_US lflags -> flags, l flags, lags
rosboost_cfg.noarch: W: no-documentation
rosboost_cfg.noarch: W: no-manual-page-for-binary rosboost-cfg
rosbuild.noarch: W: spelling-error %description -l en_US CMake -> C Make, Cake, Make
rosbuild.noarch: W: no-documentation
rosclean.noarch: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systemically
rosclean.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
rosclean.noarch: W: no-documentation
rosclean.noarch: W: no-manual-page-for-binary rosclean
roscreate.noarch: W: spelling-error Summary(en_US) filesystem -> file system, file-system, systemically
roscreate.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically
roscreate.noarch: W: spelling-error %description -l en_US xml -> XML, ml, x ml
roscreate.noarch: W: no-documentation
roscreate.noarch: W: no-manual-page-for-binary roscreate-pkg
roslang.noarch: W: spelling-error %description -l en_US rospack -> aerospace
roslang.noarch: W: no-documentation
roslang-devel.noarch: W: no-documentation
rosmake.noarch: W: spelling-error %description -l en_US roscpp -> Roscoe
rosmake.noarch: W: spelling-error %description -l en_US rospy -> rosy, ropy, prosy
rosmake.noarch: W: no-documentation
rosmake.noarch: W: no-manual-page-for-binary rosmake
ros-mk.noarch: W: spelling-error %description -l en_US cmake -> cake, make, c make
ros-mk.noarch: W: no-documentation
rosunit.noarch: W: spelling-error %description -l en_US rostest -> rosiest, roster, rooster
rosunit.noarch: W: no-documentation
rosunit.noarch: W: no-manual-page-for-binary rosunit
rosunit-devel.noarch: W: no-documentation
15 packages and 1 specfiles checked; 3 errors, 34 warnings.
screate-pkg
roslang.noarch: W: spelling-error %description -l en_US rospack -> aerospace
roslang.noarch: W: no-documentation
roslang-devel.noarch: W: no-documentation
rosmake.noarch: W: spelling-error %description -l en_US roscpp -> Roscoe
rosmake.noarch: W: spelling-error %description -l en_US rospy -> rosy, ropy, prosy
rosmake.noarch: W: no-documentation
rosmake.noarch: W: no-manual-page-for-binary rosmake
ros-mk.noarch: W: spelling-error %description -l en_US cmake -> cake, make, c make
ros-mk.noarch: W: no-documentation
rosunit.noarch: W: spelling-error %description -l en_US rostest -> rosiest, roster, rooster
rosunit.noarch: W: no-documentation
rosunit.noarch: W: no-manual-page-for-binary rosunit
rosunit-devel.noarch: W: no-documentation
15 packages and 1 specfiles checked; 3 errors, 34 warnings.