Bug 927556

Summary:	Improve the error handle about option --timeout of command blockpull , blockcopy
Product:	Red Hat Enterprise Linux 6	Reporter:	Luwen Su <lsu>
Component:	libvirt	Assignee:	Ján Tomko <jtomko>
Status:	CLOSED WONTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.4	CC:	acathrow, chhu, cwei, dyuan, jtomko, mzhan, ydu
Target Milestone:	rc	Keywords:	Upstream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	927495	Environment:
Last Closed:	2014-04-04 20:58:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	927495
Bug Blocks:

Description Luwen Su 2013-03-26 08:24:44 UTC

+++ This bug was initially created as a clone of Bug #927495 +++

Description of problem:
The issue also reproduced on rhel6 
The code about option --timeout of command blockpull , blockcopy don't handle char type properly , and then it will lead to something like

1.
#virsh blockcopy test1 vda /var/lib/libvirt/images/bak3 --wait --timeout /
Now in mirroring phase
# echo $?
0

2.
#virsh blockcopy test1 vda /var/lib/libvirt/images/bak4 --wait --timeout asdfasdf
Now in mirroring phase




Version-Release number of selected component (if applicable):
libvirt-0.10.2-18.el6_4.2.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create a domain:
#virsh create vm1.xml
Domain vm1 created from vm1.xml


2. Do block copy for vda
# time virsh blockcopy test hda /var/lib/libvirt/images/bak4 --wait --timeout ddddd --verbose
Block Copy: [ 10 %]error: failed to query job for disk hda

real	1m57.111s
user	0m0.095s
sys	0m0.026s

//i cancel the job

Comment 1 Ján Tomko 2013-03-26 16:37:42 UTC

Fixed upstream by:
commit 41db895f9e9efd51452568678759d6241e3ed84c
Author:     Ján Tomko <jtomko>
AuthorDate: 2013-03-26 16:41:06 +0100
Commit:     Ján Tomko <jtomko>
CommitDate: 2013-03-26 17:28:36 +0100

    virsh: error out on non-numeric timeout values
    
    Some block commands and migrate ignored incorrect values.

Comment 6 RHEL Program Management 2014-04-04 20:58:14 UTC

Development Management has reviewed and declined this request.
You may appeal this decision by reopening this request.