RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 927495 - Improve the error handle about option --timeout of command blockpull , blockcopy
Summary: Improve the error handle about option --timeout of command blockpull , blockcopy
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Ján Tomko
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 927556
TreeView+ depends on / blocked
 
Reported: 2013-03-26 04:37 UTC by Luwen Su
Modified: 2014-06-18 00:46 UTC (History)
8 users (show)

Fixed In Version: libvirt-1.0.4-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 927556 (view as bug list)
Environment:
Last Closed: 2014-06-13 12:19:05 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Luwen Su 2013-03-26 04:37:21 UTC
Description of problem:
The code about option --timeout of command blockpull , blockcopy don't handle char type properly , and then it will lead to something like

1.
#virsh blockcopy test1 vda /var/lib/libvirt/images/bak3 --wait --timeout /
Now in mirroring phase
# echo $?
0

2.
#virsh blockcopy test1 vda /var/lib/libvirt/images/bak4 --wait --timeout asdfasdf
Now in mirroring phase




Version-Release number of selected component (if applicable):
libvirt-1.0.3-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Create a domain:
#virsh create vm1.xml
Domain vm1 created from vm1.xml


2. Do block copy for vda
# virsh blockcopy test1 vda /var/lib/libvirt/images/bak3 --wait --timeout /

Now in mirroring phase
# echo $?
0

Actual results:
Not perproly

Expected results:
Fix it

Comment 2 Ján Tomko 2013-03-26 16:37:10 UTC
Fixed upstream by:
commit 41db895f9e9efd51452568678759d6241e3ed84c
Author:     Ján Tomko <jtomko>
AuthorDate: 2013-03-26 16:41:06 +0100
Commit:     Ján Tomko <jtomko>
CommitDate: 2013-03-26 17:28:36 +0100

    virsh: error out on non-numeric timeout values
    
    Some block commands and migrate ignored incorrect values.

Comment 3 Shanzhi Yu 2013-04-11 07:12:39 UTC
Verified pass this bug on libvirt-1.0.4-1.el7.x86_64:

# rpm -q libvirt
libvirt-1.0.4-1.el7.x86_64

1. create a domain:

#virsh create guest.xml
Domain rhel-qcow2 created from guest.xml

2. Do block copy for rhel-qcow2

# virsh blockcopy rhel-qcow2 /var/lib/libvirt/images/kvm-rhel6.2-x86_64-qcow2.img  ./ --wait --timeout /
error: invalid timeout
#echo $?
1

3. Do block pull for rhel-qcow2

# virsh blockpull rhel-qcow2 /var/lib/libvirt/images/kvm-rhel6.2-x86_64-qcow2.img  --wait --timeout /
error: invalid timeout

so set VERIFIED

Comment 4 Shanzhi Yu 2013-04-11 07:47:54 UTC
This issue can reproduce with libvirt-1.0.3-1.el7.x86_64, Verified with the packages: libvirt-1.0.4-1.el7.x86_64.

Steps as Comment 3

Comment 5 Ludek Smid 2014-06-13 12:19:05 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.


Note You need to log in before you can comment on or make changes to this bug.