Bug 928482
| Summary: | Review Request: schroedinger-cat-kde-theme - Schrödinger's Cat KDE Theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Bříza <mbriza> |
| Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jreznik, notting, package-review, rdieter |
| Target Milestone: | --- | Flags: | jreznik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-03 08:33:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 928303 | ||
|
Description
Martin Bříza
2013-03-27 18:11:09 UTC
Fixed the preview screenshots, bumped upstream version: Spec URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme.spec SRPM URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme-18.91.1-1.fc18.src.rpm Name: ok, follows schroedinger-cat-backgrounds package name
Summary: ok
Group is not needed anymore
License: ok
URL: ok
Sources: ok
Build root is not needed anymore (and rm -rf %{buildroot} in %install section)
Requires: ok
Provides: ok
Package builds: ok
rpmlint schroedinger-cat-kde-theme-18.91.1-1.fc18.src.rpm
schroedinger-cat-kde-theme.src: W: spelling-error Summary(en_US) Schrödinger's -> Schrodinger's, Schlesinger's, Schwinger's
Spelling is correct, ok
schroedinger-cat-kde-theme.src:61: W: macro-in-comment %{buildroot}
schroedinger-cat-kde-theme.src:61: W: macro-in-comment %{_kde4_appsdir}
Just TODO comments, ok
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
rpmlint /home/jreznik/rpmbuild/RPMS/noarch/schroedinger-cat-kde-theme-18.91.1-1.fc14.noarch.rpm
schroedinger-cat-kde-theme.noarch: W: unexpanded-macro dependency schroedinger-cat-backgrounds-kde >= %{backgrounds-kde-version} %{backgrounds
schroedinger-cat-kde-theme.noarch: W: spelling-error Summary(en_US) Schrödinger's -> Schrodinger's, Schlesinger's, Schwinger's
schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/2048x1536/schroedinger-cat.jpg ../../../../../../backgrounds/schroedinger-cat/default/standard/schroedinger-cat.jpg
schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/1280x1024/Schroedinger_Cat.jpg ../../../../../../backgrounds/schroedinger-cat/default/normalish/schroedinger-cat.jpg
schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/1920x1200/Schroedinger_Cat.jpg ../../../../../../backgrounds/schroedinger-cat/default/wide/schroedinger-cat.jpg
schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/SchroedingerCat/system-logo-white.png ../../../../../pixmaps/system-logo-white.png
schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/2048x1536/logo.png ../../../../../../pixmaps/system-logo-white.png
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
Symlinks are known, it's ok, provided by required package.
Btw. KSplash description in System Settings does not show correctly (maybe UTF-8 or ').
Otherwise it's fairly simple packages, based on previously approved one.
Fixed the description in ksplash and the unexpanded-macro warning: Spec URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme.spec SRPM URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme-18.91.3-1.fc18.src.rpm Thanks -> APPROVED. New Package SCM Request ======================= Package Name: schroedinger-cat-kde-theme Short Description: Schrödinger's Cat KDE Theme Owners: mbriza jreznik Branches: f19 InitialCC: Git done (by process-git-requests). |