Bug 928539

Summary: Run test suite during build
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: libexifAssignee: Petr Šabata <psabata>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: psabata, rdieter, rhbugs
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 0.6.21-5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-08 12:04:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Run test suite, fix bogus date none

Description Ville Skyttä 2013-03-27 21:00:41 UTC
Created attachment 717298 [details]
Run test suite, fix bogus date

Patch attached, along with a trivial bogus date in changelog fix. Let me know if you'd like me to push and build this for devel.

Comment 1 Petr Šabata 2013-04-02 09:36:46 UTC
There doesn't appear any real test suite in libexif and nothing gets executed on 'make test'.  The test directory serves, according to README, more like a documentation (which means it should probably be packaged...).

You could patch Makefile.* to build & execute test/*.c files properly, if you believe it would benefit the package.

I've pushed the changelog date fix now.

Comment 2 Ville Skyttä 2013-04-02 18:30:30 UTC
(In reply to comment #1)
> There doesn't appear any real test suite in libexif and nothing gets
> executed on 'make test'.

Note that my patch in the initial comment doesn't run "make test", it runs "make check" which does result in the stuff in test/ being run.

Comment 3 Petr Šabata 2013-04-29 14:23:28 UTC
Well, it seems you're right :)
Thank you.