Bug 928539 - Run test suite during build
Summary: Run test suite during build
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libexif
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-03-27 21:00 UTC by Ville Skyttä
Modified: 2013-05-08 12:04 UTC (History)
3 users (show)

Fixed In Version: 0.6.21-5
Clone Of:
Environment:
Last Closed: 2013-05-08 12:04:44 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Run test suite, fix bogus date (801 bytes, patch)
2013-03-27 21:00 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2013-03-27 21:00:41 UTC
Created attachment 717298 [details]
Run test suite, fix bogus date

Patch attached, along with a trivial bogus date in changelog fix. Let me know if you'd like me to push and build this for devel.

Comment 1 Petr Šabata 2013-04-02 09:36:46 UTC
There doesn't appear any real test suite in libexif and nothing gets executed on 'make test'.  The test directory serves, according to README, more like a documentation (which means it should probably be packaged...).

You could patch Makefile.* to build & execute test/*.c files properly, if you believe it would benefit the package.

I've pushed the changelog date fix now.

Comment 2 Ville Skyttä 2013-04-02 18:30:30 UTC
(In reply to comment #1)
> There doesn't appear any real test suite in libexif and nothing gets
> executed on 'make test'.

Note that my patch in the initial comment doesn't run "make test", it runs "make check" which does result in the stuff in test/ being run.

Comment 3 Petr Šabata 2013-04-29 14:23:28 UTC
Well, it seems you're right :)
Thank you.


Note You need to log in before you can comment on or make changes to this bug.