Bug 929189

Summary:	Review Request: python-flask-script - Scripting support for Flask
Product:	[Fedora] Fedora	Reporter:	Robert Kuska <rkuska>
Component:	Package Review	Assignee:	Bohuslav "Slavek" Kabrda <bkabrda>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bkabrda, jberan, notting, package-review
Target Milestone:	---	Flags:	bkabrda: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-04-23 03:44:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert Kuska 2013-03-29 12:59:49 UTC

Spec URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script.spec
SRPM URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script-0.5.3-1.fc18.src.rpm
Description: The Flask-Script extension provides support for writing external scripts in Flask.This includes running a development server, a customized Python shell, scripts to set up your database, cronjobs, and other command-line tasks that belong outside the web application itself.
Fedora Account System Username: rkuska

Comment 1 Bohuslav "Slavek" Kabrda 2013-03-29 13:01:19 UTC

I'll take this for a review.

Comment 2 Bohuslav "Slavek" Kabrda 2013-04-02 07:28:20 UTC

- python_sitelib and python_sitearch definitions aren't needed any more, please remove them.
- "rm -rf $RPM_BUILD_ROOT" in %install is not needed either
- rpmlint reports a tiny problem about mixed spaces/tabs - certainly not a blocker but please fix it to silence rpmlint:
python-flask-script.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 21, tab: line 6)
- I don't think including the whole docs/ directory makes much sense. If look at its contents, these are sphinx [1] documentation sources, not a generated documentation. Therefore, I would suggest using sphinx to create html (cd docs && make html) and including the html directory in %docs (it will be something like docs/_build/html).
- PKG-INFO shouldn't be included in %docs, it's not intended to be a documentation file.

[1] http://sphinx-doc.org/

Comment 3 Robert Kuska 2013-04-02 13:27:45 UTC

Fixed:

Spec URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script.spec
SRPM URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script-0.5.3-2.fc18.src.rpm

Comment 4 Bohuslav "Slavek" Kabrda 2013-04-02 13:37:57 UTC

Looks good now,

APPROVED.

Comment 5 Robert Kuska 2013-04-02 14:08:48 UTC

New Package SCM Request
=======================
Package Name: python-flask-script
Short Description: Scripting support for Flask
Owners: rkuska
Branches: f19
InitialCC:

Comment 6 Gwyn Ciesla 2013-04-02 14:15:32 UTC

Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-04-03 12:21:08 UTC

python-flask-script-0.5.3-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-flask-script-0.5.3-2.fc19

Comment 8 Fedora Update System 2013-04-03 16:16:21 UTC

python-flask-script-0.5.3-2.fc19 has been pushed to the Fedora 19 testing repository.

Comment 9 Fedora Update System 2013-04-23 03:44:17 UTC

python-flask-script-0.5.3-2.fc19 has been pushed to the Fedora 19 stable repository.