Spec URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script.spec SRPM URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script-0.5.3-1.fc18.src.rpm Description: The Flask-Script extension provides support for writing external scripts in Flask.This includes running a development server, a customized Python shell, scripts to set up your database, cronjobs, and other command-line tasks that belong outside the web application itself. Fedora Account System Username: rkuska
I'll take this for a review.
- python_sitelib and python_sitearch definitions aren't needed any more, please remove them. - "rm -rf $RPM_BUILD_ROOT" in %install is not needed either - rpmlint reports a tiny problem about mixed spaces/tabs - certainly not a blocker but please fix it to silence rpmlint: python-flask-script.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 21, tab: line 6) - I don't think including the whole docs/ directory makes much sense. If look at its contents, these are sphinx [1] documentation sources, not a generated documentation. Therefore, I would suggest using sphinx to create html (cd docs && make html) and including the html directory in %docs (it will be something like docs/_build/html). - PKG-INFO shouldn't be included in %docs, it's not intended to be a documentation file. [1] http://sphinx-doc.org/
Fixed: Spec URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script.spec SRPM URL: http://rkuska.fedorapeople.org/pkgs/flask-script/python-flask-script-0.5.3-2.fc18.src.rpm
Looks good now, APPROVED.
New Package SCM Request ======================= Package Name: python-flask-script Short Description: Scripting support for Flask Owners: rkuska Branches: f19 InitialCC:
Git done (by process-git-requests).
python-flask-script-0.5.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-flask-script-0.5.3-2.fc19
python-flask-script-0.5.3-2.fc19 has been pushed to the Fedora 19 testing repository.
python-flask-script-0.5.3-2.fc19 has been pushed to the Fedora 19 stable repository.