Bug 929200
| Summary: | RFE: [as7] Use Commons HttpClient in ASConnection instead of JDK's HttpUrlConnection | |||
|---|---|---|---|---|
| Product: | [JBoss] JBoss Operations Network | Reporter: | Thomas Segismont <tsegismo> | |
| Component: | Plugin -- JBoss EAP 6 | Assignee: | Thomas Segismont <tsegismo> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | |
| Severity: | high | Docs Contact: | ||
| Priority: | urgent | |||
| Version: | JON 3.1.2 | CC: | hrupp, loleary | |
| Target Milestone: | ER01 | |||
| Target Release: | JON 3.2.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 929198 | |||
| : | 950660 (view as bug list) | Environment: | ||
| Last Closed: | Type: | Bug | ||
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 929198 | |||
| Bug Blocks: | 918677, 950660, 953152 | |||
|
Description
Thomas Segismont
2013-03-29 13:23:16 UTC
See BZ918677 for the type of problems we have with JDK's HttpUrlConnection Since this seems to be related more to fixing a bug than adding a feature I've removed the FutureFeature keyword. I've also unset the Target Release field to make sure this gets triaged. A change in the http library used by the AS7 plugin will require a full regression test run, since http communication is used so widely to talk to AS7 BZ918677 has been partially fixed (only works on some platforms). Moving ASConnection to Commons HttpClient will allow to get rid of the problem on all platforms. ASConnection is the core communication component of AS7 plugin. Changing its implementation will involve extensive non regression testing from QE before the next JON release. But as ASUploadConnection has already been moved to commons HttpClient due to BZ887320, it has to be done anyway. As for the benefits of this change: * cohesion between ASConnection and ASUploadConnection implementations * easier debugging as JDK's HttpUrlConnection is closed source (at least in Oracle's VM) * Commons HttpClient gives the developer more control on the communication process (when/how open or close connections, configurable pooling, unshared authentication) And for the risks. No instance of HttpUrlConnection is shared outside ASConnection. So components in AS7 plugin only rely on ASConnection contract. Consequently, while ASConnection is the core communication component of AS7 plugin, the risk of regression is very low. Fixed in master - 21ec5e2 AS7 plugin itests passed succesfully Beware that this touches the core connection part (ASConnection class) and hence requires a full non regresssion testing of AS7 plugin. Reworked to increased delay in AS7 itests to discover all resources master - 3b18013 All as7 plugin unit and integration tests pass on my box and on Jenkins: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/RHQ/job/rhq-master/org.rhq$rhq-jboss-as-7-plugin/ *** Bug 913737 has been marked as a duplicate of this bug. *** Moving back to ON_DEV as this fix seems to introduce regressions. See comment in downstream bug 951738#c4. Moving to MODIFIED as regressions were adressed As this is MODIFIED or ON_QA, setting milestone to ER1. As this is MODIFIED or ON_QA, setting milestone to ER01. this was verified |