Bug 947509

Summary: Review Request: glassfish-annotation-api - Common Annotations API Specification (JSR 250)
Product: [Fedora] Fedora Reporter: gil cattaneo <puntogil>
Component: Package ReviewAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, tcallawa
Target Milestone: ---Flags: tcallawa: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glassfish-annotation-api-1.2-3.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-08 03:36:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 895810, 965930    
Bug Blocks: 947511, 962839    

Description gil cattaneo 2013-04-02 15:48:13 UTC
Spec URL: http://gil.fedorapeople.org/glassfish-annotation-api.spec
SRPM URL: http://gil.fedorapeople.org/glassfish-annotation-api-1.2-0.1.b04.fc18.src.rpm
Description: Common Annotations for the JavaTM Platform API.

Fedora Account System Username: gil

Comment 2 gil cattaneo 2013-05-09 02:36:03 UTC
Spec URL: http://gil.fedorapeople.org/glassfish-annotation-api.spec
SRPM URL: http://gil.fedorapeople.org/glassfish-annotation-api-1.2-1.fc18.src.rpm

Description: Common Annotations APIs for the Java Platform (JSR 250).

Comment 3 gil cattaneo 2013-05-09 02:51:46 UTC
This package is needed for jersey JAX-RS  2.0 (JSR 339) production quality Reference Implementation

Comment 4 Tom "spot" Callaway 2013-05-16 14:55:07 UTC
= Review =

Good:

- rpmlint checks return:

glassfish-annotation-api.src: W: invalid-url Source0: glassfish-annotation-api-1.2-src-svn.tar.gz

Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (CDDL or GPLv2 with exceptions) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff okay, due to SVN source)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

Comment 5 gil cattaneo 2013-05-16 15:02:48 UTC
Thanks for the review

New Package SCM Request
=======================
Package Name: glassfish-annotation-api
Short Description: Common Annotations API Specification (JSR 250)
Owners: gil
Branches: f18 f19
InitialCC: java-sig

Comment 6 Gwyn Ciesla 2013-05-16 15:30:25 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2013-05-31 09:54:34 UTC
glassfish-annotation-api-1.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/glassfish-annotation-api-1.2-3.fc19

Comment 8 Fedora Update System 2013-05-31 10:06:48 UTC
glassfish-annotation-api-1.2-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/glassfish-annotation-api-1.2-3.fc18

Comment 9 Fedora Update System 2013-05-31 18:10:38 UTC
glassfish-annotation-api-1.2-3.fc19 has been pushed to the Fedora 19 testing repository.

Comment 10 Fedora Update System 2013-06-08 03:36:34 UTC
glassfish-annotation-api-1.2-3.fc19 has been pushed to the Fedora 19 stable repository.

Comment 11 Fedora Update System 2013-06-09 02:23:07 UTC
glassfish-annotation-api-1.2-3.fc18 has been pushed to the Fedora 18 stable repository.