Bug 947634

Summary: anaconda Installation Source ISO FILE "OSError: [Errno 20] Not a directory" when selecting an invalid file as the ISO Image Installation Source
Product: [Fedora] Fedora Reporter: Reartes Guillermo <rtguille>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 19CC: anaconda-maint-list, awilliam, g.kaviyarasu, jonathan, mkolman, sbueno, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: anaconda-19.17-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-14 23:04:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
anaconda-tb-xxx file
none
anaconda.log
none
storage.log
none
program.log
none
packaging log
none
scrren-shot selecting the file none

Description Reartes Guillermo 2013-04-02 22:03:10 UTC
Created attachment 730993 [details]
anaconda-tb-xxx file

Description of problem:

One can select an invalid file for the Installation Source 'ISO File' and Anaconda will crash instead
of refuse to use the file.

Version-Release number of selected component (if applicable):
F19a TC3 (19.14)

How reproducible:
always

Steps to Reproduce:

0. Boot F19a TC3 DVD Media
1. Reach the Main Hub, leave defaults in the Welcome Screen
2. Change the Keyboard, if needed (i used Spanish) (i also set the DATE & TIME)
3. Enter SOFTWARE: Installation Source Spoke
4. Select 'ISO File' and select a random file (not an ISO) in 'Choose an ISO'
5. Return to the Main Hub, anaconda will crash


Actual results:
anaconda crashes

Expected results:
reject the selected file as invalid, no crash

Additional Info:

anaconda 19.14 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/image.py", line 55, in findFirstIsoImage
    files = os.listdir(path)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/packaging/yumpayload.py", line 575, in _setUpMedia
    image = findFirstIsoImage(path)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/packaging/yumpayload.py", line 645, in _configureBaseRepo
    self._setUpMedia(isodevice)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/packaging/yumpayload.py", line 459, in updateBaseRepo
    self._configureBaseRepo(self.storage, checkmount=checkmount)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/source.py", line 419, in getRepoMetadata
    self.payload.updateBaseRepo(fallback=False, checkmount=False)
  File "/usr/lib64/python2.7/threading.py", line 504, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 141, in run
    threading.Thread.run(self, *args, **kwargs)
OSError: [Errno 20] Not a directory: '/mnt/install/isodir/grub2/themes/system/boot_menu_c.png'

Comment 1 Reartes Guillermo 2013-04-02 22:03:36 UTC
Created attachment 730994 [details]
anaconda.log

Comment 2 Reartes Guillermo 2013-04-02 22:04:00 UTC
Created attachment 730995 [details]
storage.log

Comment 3 Reartes Guillermo 2013-04-02 22:04:29 UTC
Created attachment 730996 [details]
program.log

Comment 4 Reartes Guillermo 2013-04-02 22:04:48 UTC
Created attachment 730997 [details]
packaging log

Comment 5 Reartes Guillermo 2013-04-02 22:05:28 UTC
Created attachment 730998 [details]
scrren-shot selecting the file

Comment 6 Fedora Update System 2013-04-09 22:57:51 UTC
python-blivet-0.10-1.fc19,anaconda-19.17-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-blivet-0.10-1.fc19,anaconda-19.17-1.fc19

Comment 7 Fedora Update System 2013-04-10 15:19:06 UTC
Package python-blivet-0.10-1.fc19, anaconda-19.17-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-blivet-0.10-1.fc19 anaconda-19.17-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5323/python-blivet-0.10-1.fc19,anaconda-19.17-1.fc19
then log in and leave karma (feedback).

Comment 8 Adam Williamson 2013-05-14 22:01:24 UTC
Reartes, can you confirm that this is resolved with more recent F19 builds? Thanks!

Comment 9 Reartes Guillermo 2013-05-14 22:35:53 UTC
I seems fixed, i selected an random file and it is now rejected. In the Main Hub, the Installation Source is not setup, with a Yellow Banner, but no crash.

Selecting back the DVD after the Yellow Banner does also work ok.
I can safely assume this can be closed.

Comment 10 Reartes Guillermo 2013-05-14 22:55:05 UTC
Bad luck, while it does not crash, it the installation source screen now distorts. (See Bug 962994). 

This still can be closed. (I think).

Comment 11 Adam Williamson 2013-05-14 23:04:36 UTC
Yeah, that's a different bug. Thanks for re-testing, let's close this one.